+1 one more minor nit, please update the KIP with the link to the discuss thread too.
~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Sun, Mar 15, 2015 at 5:27 PM, Neha Narkhede <n...@confluent.io> wrote: > +1 on the KIP. Minor nit: "it is deemed to not be in ISR because it is not > caught up" => "it is deemed to not be in the ISR because it has fallen > behind for more than a certain amount of time as controlled by this config" > > Also took a look at the patch. Looks correct, left review comments. Thanks > for sharing the test results. This change is going to be great for users! > > On Sat, Mar 14, 2015 at 9:01 AM, Jay Kreps <jay.kr...@gmail.com> wrote: > > > +1 > > > > -Jay > > > > On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar < > > aaurad...@linkedin.com.invalid> wrote: > > > > > Details in the KIP, Jira and RB. > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning > > > https://issues.apache.org/jira/browse/KAFKA-1546 > > > https://reviews.apache.org/r/31967/ > > > > > > Aditya > > > > > > > > > > > > -- > Thanks, > Neha >
