Review Request 30477: Patch for KAFKA-1907

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30477/ --- Review request for kafka. Bugs: KAFKA-1907 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299832#comment-14299832 ] jaikiran pai commented on KAFKA-1907: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jaikiran pai updated KAFKA-1907: Attachment: KAFKA-1907.patch > ZkClient can block controlled shutdown indefinitely > ---

[jira] [Updated] (KAFKA-1907) ZkClient can block controlled shutdown indefinitely

[ https://issues.apache.org/jira/browse/KAFKA-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jaikiran pai updated KAFKA-1907: Assignee: jaikiran pai Status: Patch Available (was: Open) > ZkClient can block controlled sh

Re: Cannot stop Kafka server if zookeeper is shutdown first

Neha, Ewen (and others), my initial attempt to solve this is uploaded here https://reviews.apache.org/r/30477/. It solves the shutdown problem and now the server shuts down even when Zookeeper has gone down before the Kafka server. I went with the approach of introducing a custom (enhanced) Zk

Re: Review Request 30403: Patch for KAFKA-1906

Hi Jeff, I guess you are :) Personally, whenever I download and try a new project *in development environment* I always just want to get it up and running without having to fiddle with configurations. Of course, I do a bit of reading the docs, before trying it out, but I like to have the inst

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70508 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70509 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

[jira] [Updated] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1633: - Assignee: Guozhang Wang (was: Jun Rao) Status: Patch Available (was: Open) > Data loss if

[jira] [Updated] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1633: - Attachment: KAFKA-1633.patch > Data loss if broker is killed > - > >

[jira] [Commented] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300047#comment-14300047 ] Guozhang Wang commented on KAFKA-1633: -- Created reviewboard https://reviews.apache.or

Review Request 30482: Add the coordinator to server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- Review request for kafka. Bugs: KAFKA-1633 https://issues.apache.org/jira/b

[jira] [Issue Comment Deleted] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1633: - Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/30482/diff/ against b

Re: Review Request 30482: Add the coordinator to server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 1:40 a.m.) Review request for kafka. Bugs: KAFKA-1333

[jira] [Updated] (KAFKA-1333) Add consumer co-ordinator module to the server

[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1333: - Attachment: KAFKA-1333_2015-01-31_17:40:51.patch > Add consumer co-ordinator module to the server

[jira] [Updated] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1633: - Attachment: (was: KAFKA-1633.patch) > Data loss if broker is killed >

[jira] [Updated] (KAFKA-1333) Add consumer co-ordinator module to the server

[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1333: - Status: Patch Available (was: Open) > Add consumer co-ordinator module to the server > --

[jira] [Commented] (KAFKA-1333) Add consumer co-ordinator module to the server

[ https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300048#comment-14300048 ] Guozhang Wang commented on KAFKA-1333: -- Updated reviewboard https://reviews.apache.or

[jira] [Created] (KAFKA-1910) Refactor KafkaConsumer

Guozhang Wang created KAFKA-1910: Summary: Refactor KafkaConsumer Key: KAFKA-1910 URL: https://issues.apache.org/jira/browse/KAFKA-1910 Project: Kafka Issue Type: Sub-task Reporte

Re: Review Request 30482: Add the coordinator to server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 1:47 a.m.) Review request for kafka. Bugs: KAFKA-1333

[jira] [Assigned] (KAFKA-1892) System tests for the new consumer and co-ordinator

[ https://issues.apache.org/jira/browse/KAFKA-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-1892: Assignee: Guozhang Wang > System tests for the new consumer and co-ordinator >

[jira] [Assigned] (KAFKA-1335) Add rebalancing logic to the coordinator / consumer

[ https://issues.apache.org/jira/browse/KAFKA-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-1335: Assignee: Guozhang Wang > Add rebalancing logic to the coordinator / consumer > ---

[jira] [Commented] (KAFKA-1633) Data loss if broker is killed

[ https://issues.apache.org/jira/browse/KAFKA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300051#comment-14300051 ] Guozhang Wang commented on KAFKA-1633: -- Mistakenly submitted a patch which is for KAF

Re: [VOTE] 0.8.2.0 Candidate 3

Hi, Alex, Thanks for testing RC3. Broker.connectionString() is actually not part of the public api for the producer. Is there a particular reason that you need to use this api? Thanks, Jun On Sat, Jan 31, 2015 at 1:53 PM, Alex The Rocker wrote: > Hello, > > I have read Broker.scala source co

Re: Review Request 30482: Add the coordinator to server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ --- (Updated Feb. 1, 2015, 2:45 a.m.) Review request for kafka. Bugs: KAFKA-1333

Re: [VOTE] 0.8.2.0 Candidate 3

+1 (binding). Verified quickstart and unit tests. Thanks, Jun On Wed, Jan 28, 2015 at 11:22 PM, Jun Rao wrote: > This is the third candidate for release of Apache Kafka 0.8.2.0. > > Release Notes for the 0.8.2.0 release > > https://people.apache.org/~junrao/kafka-0.8.2.0-candidate3/RELEASE_NOT

Re: Cannot stop Kafka server if zookeeper is shutdown first

It looks like the new KafkaZkClient is a wrapper around ZkClient, but not a replacement. Did I get it right? I think a wrapper for ZkClient can be useful - for example KAFKA-1664 can also use one. However, I'm wondering why not contribute the fix directly to ZKClient project and ask for a release

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70523 --- I like the idea of a message handler in MirrorMaker, but I think we

[jira] [Created] (KAFKA-1911) Log deletion on stopping replicas should be async

Joel Koshy created KAFKA-1911: - Summary: Log deletion on stopping replicas should be async Key: KAFKA-1911 URL: https://issues.apache.org/jira/browse/KAFKA-1911 Project: Kafka Issue Type: Bug

Re: Review Request 30063: Patch for KAFKA-1840

> On Feb. 1, 2015, 6:34 a.m., Gwen Shapira wrote: > > I like the idea of a message handler in MirrorMaker, but I think we can do > > better. Let me know if you think I'm taking it far beyond your original > > scope... I can add it as a follow up jira. > > > > 1. I think we need to let users pa