----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30482/ -----------------------------------------------------------
(Updated Feb. 1, 2015, 1:47 a.m.) Review request for kafka. Bugs: KAFKA-1333 and KAFKA-1633 https://issues.apache.org/jira/browse/KAFKA-1333 https://issues.apache.org/jira/browse/KAFKA-1633 Repository: kafka Description (updated) ------- 1. Add ConsumerCoordinator with GroupRegistry and ConsumerRegistry metadata, and ZK listeners. 2. Add a delayed heartbeat purgatory based on HeartbeatBucket to expire heartbeat requests. 3. Add a delayed rebalance purgatory for preparing rebalance. 4. Add a join-group purgatory for sending back responses with assigned partitions. 5. Add TimeMsKey / ConsumerKey and ConsumerGroupKey for delayed heartbeat / join-group / rebalance purgatories. 6. Refactor KafkaApis for handling JoinGroup / Heartbeat requests with coordinator, and sending reponses via callbacks. Diffs ----- core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala PRE-CREATION core/src/main/scala/kafka/coordinator/GroupRegistry.scala PRE-CREATION core/src/main/scala/kafka/coordinator/HeartbeatBucket.scala PRE-CREATION core/src/main/scala/kafka/server/DelayedOperationKey.scala fb7e9ed5c16dd15b71e1b1ac12948641185871db core/src/main/scala/kafka/server/KafkaApis.scala f2b027bf944e735fd52cc282690ec1b8395f9290 core/src/main/scala/kafka/server/KafkaServer.scala 89200da30a04943f0b9befe84ab17e62b747c8c4 Diff: https://reviews.apache.org/r/30482/diff/ Testing ------- Thanks, Guozhang Wang