[jira] [Updated] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

2014-04-21 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Bugaychenko updated KAFKA-1408: -- Description: After getting to inconsistence state due to short netwrok failure broker c

[jira] [Commented] (KAFKA-1407) Broker can not return to ISR because of BadVersionException

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975605#comment-13975605 ] Jun Rao commented on KAFKA-1407: When this happens, do you see any connection loss to ZK?

[jira] [Comment Edited] (KAFKA-1407) Broker can not return to ISR because of BadVersionException

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975605#comment-13975605 ] Jun Rao edited comment on KAFKA-1407 at 4/21/14 2:55 PM: - When thi

[jira] [Commented] (KAFKA-1408) Kafk broker can not stop itself normaly after problems with connection to ZK

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975613#comment-13975613 ] Jun Rao commented on KAFKA-1408: The deadlock issue is fixed in the latest 0.8.1 branch as

[jira] [Created] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-21 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1409: -- Summary: oversized messages can slow down the brokers Key: KAFKA-1409 URL: https://issues.apache.org/jira/browse/KAFKA-1409 Project: Kafka Issue Type: Bug Comp

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975717#comment-13975717 ] Jun Rao commented on KAFKA-1409: The fix would be: 1. add an extra verification of the mes

[jira] [Commented] (KAFKA-1356) Topic metadata requests takes too long to process

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975787#comment-13975787 ] Jun Rao commented on KAFKA-1356: Joel, I overlooked one issue. With your latest change, i

[jira] [Commented] (KAFKA-1405) Global JSON.globalNumberParser screws up other libraries

2014-04-21 Thread Vadim Chekan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975828#comment-13975828 ] Vadim Chekan commented on KAFKA-1405: - Hi Jun, Thanks for quick response. Seems JSON

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975859#comment-13975859 ] Joel Koshy commented on KAFKA-1380: --- * Log cleaner metrics have also been checked in, al

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975866#comment-13975866 ] Guozhang Wang commented on KAFKA-1359: -- Created reviewboard against branch origin/tr

Review Request 20529: Follow-up KAFKA-1359: change nanoTime to currentTimeMillis in metrics, fix a small issue for metadata age calculation

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/ --- Review request for kafka. Bugs: KAFKA-1359 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359.patch > Add topic/broker metrics once new topic/broker is discovered > ---

Re: Review Request 20468: Add log cleaner metrics. (Cherry-picked from trunk)

2014-04-21 Thread Joel Koshy
> On April 19, 2014, 12:42 a.m., Jun Rao wrote: > > Also, I think we need to make the following var volatile. > > > > CleanerStats.startTime, mapCompleteTime, endTime, bytesRead, bytesWritten, > > mapBytesRead, mapMessagesRead, messagesRead, messagesWritten > > > > LogCleanerManager.dirtiestLo

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380.patch > 0.8.1.1 release candidate > - > >

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975875#comment-13975875 ] Guozhang Wang commented on KAFKA-1359: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359.patch > Add topic/broker metrics once new topic/broker is discovered > ---

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975877#comment-13975877 ] Joel Koshy commented on KAFKA-1380: --- Created reviewboard against branch origin/0.8.1 >

Re: Review Request 20529: Follow-up KAFKA-1359: change nanoTime to currentTimeMillis in metrics, fix a small issue for metadata age calculation

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/ --- (Updated April 21, 2014, 6:45 p.m.) Review request for kafka. Bugs: KAFKA-135

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975882#comment-13975882 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-21_11:45:53.patch > Add topic/broker metrics once new topic/broker

[jira] Subscription: outstanding kafka patches

2014-04-21 Thread jira
Issue Subscription Filter: outstanding kafka patches (84 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1395 fix unit tests in AutoOffsetResetTest https://issues.apache.org/jira/browse/KAFKA-1395 KAFKA-1394 Ensure last segment i

Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/ --- Review request for kafka. Bugs: KAFKA-1380 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975987#comment-13975987 ] Joel Koshy commented on KAFKA-1380: --- Created reviewboard against branch origin/0.8.1 >

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380.patch > 0.8.1.1 release candidate > - > >

[jira] [Comment Edited] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975987#comment-13975987 ] Joel Koshy edited comment on KAFKA-1380 at 4/21/14 8:25 PM: Cr

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/#review40945 --- Ship it! Ship It! - Neha Narkhede On April 21, 2014, 8:21 p.m.,

Re: Review Request 20529: Follow-up KAFKA-1359: change nanoTime to currentTimeMillis in metrics, fix a small issue for metadata age calculation

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/#review40949 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/ --- Review request for kafka. Bugs: KAFKA-1380 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1409: - Fix Version/s: 0.8.2 > oversized messages can slow down the brokers > ---

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380.patch > 0.8.1.1 release candidate > - > >

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

2014-04-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1409: - Priority: Critical (was: Major) > oversized messages can slow down the brokers > ---

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976074#comment-13976074 ] Joel Koshy commented on KAFKA-1380: --- Created reviewboard https://reviews.apache.org/r/20

Re: Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/#review40959 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/#review40961 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/#review40962 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/ --- (Updated April 21, 2014, 9:47 p.m.) Review request for kafka. Bugs: KAFKA-138

Re: Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/ --- (Updated April 21, 2014, 9:48 p.m.) Review request for kafka. Bugs: KAFKA-138

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380_2014-04-21_14:47:27.patch > 0.8.1.1 release candidate >

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976088#comment-13976088 ] Joel Koshy commented on KAFKA-1380: --- Updated reviewboard https://reviews.apache.org/r/20

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380_2014-04-21_14:48:56.patch > 0.8.1.1 release candidate >

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976090#comment-13976090 ] Joel Koshy commented on KAFKA-1380: --- Updated reviewboard https://reviews.apache.org/r/20

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/#review40966 --- Ship it! Ship It! - Neha Narkhede On April 21, 2014, 9:47 p.m.,

Re: Review Request 20536: Patch for KAFKA-1380

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/#review40967 --- Ship it! Ship It! - Neha Narkhede On April 21, 2014, 9:48 p.m.,

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/#review40968 --- Ship it! Ship It! - Timothy Chen On April 21, 2014, 9:47 p.m., J

[jira] [Resolved] (KAFKA-1393) I wrote this conflicted ephemeral node at /brokers/ids/199 a while back in a different session, hence I will backoff for this node to be deleted by Zookeeper and retry

2014-04-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1393. -- Resolution: Duplicate Duplicate of KAFKA-1387 > I wrote this conflicted ephemeral node at /br

Re: Review Request 20534: Patch for KAFKA-1380

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20534/#review40971 --- Ship it! Ship It! - Jun Rao On April 21, 2014, 9:47 p.m., Joel K

Re: Review Request 20380: Fix KAFKA-1395: incorporate Jun's comment

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/#review40972 --- core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scal

Review Request 20537: Patch for KAFKA-1400

2014-04-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20537/ --- Review request for kafka. Bugs: KAFKA-1400 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1400) transient unit test failure in SocketServerTest

2014-04-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1400: - Attachment: KAFKA-1400.patch > transient unit test failure in SocketServerTest >

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2014-04-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976121#comment-13976121 ] Neha Narkhede commented on KAFKA-1400: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1380: -- Attachment: KAFKA-1380.patch > 0.8.1.1 release candidate > - > >

Review Request 20538: Patch for KAFKA-1380

2014-04-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20538/ --- Review request for kafka. Bugs: KAFKA-1380 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976136#comment-13976136 ] Joel Koshy commented on KAFKA-1380: --- Created reviewboard https://reviews.apache.org/r/20

[jira] [Created] (KAFKA-1410) MetadataCache cleanup

2014-04-21 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1410: -- Summary: MetadataCache cleanup Key: KAFKA-1410 URL: https://issues.apache.org/jira/browse/KAFKA-1410 Project: Kafka Issue Type: Bug Components: core Affect

Review Request 20540: Patch for KAFKA-1410

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/ --- Review request for kafka. Bugs: KAFKA-1410 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1410) MetadataCache cleanup

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1410: --- Attachment: KAFKA-1410.patch > MetadataCache cleanup > - > > Key: KAFKA-1

[jira] [Commented] (KAFKA-1410) MetadataCache cleanup

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976165#comment-13976165 ] Jun Rao commented on KAFKA-1410: Created reviewboard https://reviews.apache.org/r/20540/

[jira] [Created] (KAFKA-1411) remove unused test cases

2014-04-21 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1411: -- Summary: remove unused test cases Key: KAFKA-1411 URL: https://issues.apache.org/jira/browse/KAFKA-1411 Project: Kafka Issue Type: Test Components: core Af

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-21_16:29:02.patch > Add topic/broker metrics once new topic/broker

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976181#comment-13976181 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard against branch origin/tr

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976183#comment-13976183 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard against branch origin/tr

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-21_16:30:57.patch > Add topic/broker metrics once new topic/broker

Re: Review Request 20529: Follow-up KAFKA-1359: incorporate Neha's comments

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20529/ --- (Updated April 21, 2014, 11:33 p.m.) Review request for kafka. Summary (updat

Review Request 20541: Patch for KAFKA-1411

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/ --- Review request for kafka. Bugs: KAFKA-1411 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1359: - Attachment: KAFKA-1359_2014-04-21_16:33:22.patch > Add topic/broker metrics once new topic/broker

[jira] [Updated] (KAFKA-1411) remove unused test cases

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1411: --- Attachment: KAFKA-1411.patch > remove unused test cases > > > Key: K

[jira] [Commented] (KAFKA-1411) remove unused test cases

2014-04-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976189#comment-13976189 ] Jun Rao commented on KAFKA-1411: Created reviewboard https://reviews.apache.org/r/20541/

[jira] [Commented] (KAFKA-1359) Add topic/broker metrics once new topic/broker is discovered

2014-04-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976187#comment-13976187 ] Guozhang Wang commented on KAFKA-1359: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 20538: Patch for KAFKA-1380

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20538/#review40978 --- Ship it! Ship It! - Jun Rao On April 21, 2014, 10:40 p.m., Joel

Re: Review Request 20537: Patch for KAFKA-1400

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20537/#review40979 --- Ship it! Ship It! - Guozhang Wang On April 21, 2014, 10:27 p.m.,

Re: Review Request 20540: Patch for KAFKA-1410

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review40980 --- This patch is much larger than it is claimed to be :) Any rebasing m

Re: Review Request 20541: Patch for KAFKA-1411

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review40981 --- core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <

[jira] [Commented] (KAFKA-1380) 0.8.1.1 release candidate

2014-04-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976229#comment-13976229 ] Joel Koshy commented on KAFKA-1380: --- All the issues have been resolved and patches have

Re: Review Request 20537: Patch for KAFKA-1400

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20537/#review40987 --- Ship it! Ship It! - Jun Rao On April 21, 2014, 10:27 p.m., Neha

[DISCUSS] 0.8.1.1 Release

2014-04-21 Thread Joe Stein
It looks like everything on the 0.8.1 branch is ready for release. I plan on tagging and publishing the artifacts and a calling vote likely tomorrow unless there is anything else? /*** Joe Stein Founder, Principal Consultant Big Data Open Source Securi

Build failed in Jenkins: Kafka-trunk #169

2014-04-21 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-1327; Log cleaner metrics follow-up patch to reset dirtiest log cleanable ratio; reviewed by Jun Rao -- [...truncated 373 lines...] kafka.admin.AdminTest > testTopicConfi

Re: [DISCUSS] 0.8.1.1 Release

2014-04-21 Thread Joel Koshy
Sounds good - thanks Joe! Joel On Mon, Apr 21, 2014 at 08:05:29PM -0700, Joe Stein wrote: > It looks like everything on the 0.8.1 branch is ready for release. I plan on > tagging and publishing the artifacts and a calling vote likely tomorrow > unless there is anything else? > > /