[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825487#comment-13825487 ] Jun Rao commented on KAFKA-1112: Thinking about this a bit more. The end state is that we

[jira] [Updated] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

2013-11-18 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1134: - Affects Version/s: 0.8.1 0.8 > onControllerFailover function should be syn

Re: Review Request 15201: address Neha's review comments

2013-11-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/ --- (Updated Nov. 18, 2013, 5:57 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825532#comment-13825532 ] Jun Rao commented on KAFKA-1117: Updated reviewboard https://reviews.apache.org/r/15201/

[jira] [Updated] (KAFKA-1117) tool for checking the consistency among replicas

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1117: --- Attachment: KAFKA-1117_2013-11-18_09:58:23.patch > tool for checking the consistency among replicas > ---

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825588#comment-13825588 ] Guozhang Wang commented on KAFKA-1112: -- Did some research on network about "fsync", a

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825620#comment-13825620 ] Neha Narkhede commented on KAFKA-1112: -- [~junrao] This approach seems reasonable unle

[jira] Subscription: outstanding kafka patches

2013-11-18 Thread jira
Issue Subscription Filter: outstanding kafka patches (75 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1131 copy some more files into the release tar and zip that are needed/desired https://issues.apache.org/jira/browse/KAFKA-1

Re: Review Request 15201: address Neha's review comments

2013-11-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review29067 --- Ship it! Ship It! - Neha Narkhede On Nov. 18, 2013, 5:57 p.m., J

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825708#comment-13825708 ] Jay Kreps commented on KAFKA-1112: -- Yeah at a high-level there are a couple of things we

[jira] [Updated] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1112: --- Attachment: KAFKA-1112-v4.patch Ok, so it seems that the end state is not that simple and may need some more

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825863#comment-13825863 ] Guozhang Wang commented on KAFKA-1103: -- Since this is closely related to KAFKA-1004,

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825893#comment-13825893 ] Neha Narkhede commented on KAFKA-1112: -- Thanks for the patch, Jun! Overall, looks goo

[jira] [Commented] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825922#comment-13825922 ] Jay Kreps commented on KAFKA-1112: -- +1 lgtm. > broker can not start itself after kafka i

Review Request 15659: Patch for KAFKA-1103

2013-11-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/ --- Review request for kafka. Bugs: KAFKA-1103 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1103) Consumer uses two zkclients

2013-11-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1103: - Attachment: KAFKA-1103.patch > Consumer uses two zkclients > --- > >

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-18 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825942#comment-13825942 ] Guozhang Wang commented on KAFKA-1103: -- Created reviewboard https://reviews.apache.or

[jira] [Resolved] (KAFKA-1112) broker can not start itself after kafka is killed with -9

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1112. Resolution: Fixed Fix Version/s: 0.8.1 Thanks for the reviews. Committed to trunk after addressing N

[jira] [Created] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-1135: Summary: Code cleanup - use Json.encode() to write json data to zk Key: KAFKA-1135 URL: https://issues.apache.org/jira/browse/KAFKA-1135 Project: Kafka Issue

Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- Review request for kafka. Bugs: KAFKA-1135 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826116#comment-13826116 ] Swapnil Ghike commented on KAFKA-1135: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135.patch > Code cleanup - use Json.encode() to write json data to zk > --

Re: Review Request 15665: Code clean: use Json.encode() to write json data to zookeeper

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- (Updated Nov. 19, 2013, 3:16 a.m.) Review request for kafka. Bugs: KAFKA-1135

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:17:54.patch > Code cleanup - use Json.encode() to write json

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- (Updated Nov. 19, 2013, 3:17 a.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826128#comment-13826128 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 15665: Patch for KAFKA-1135

2013-11-18 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15665/ --- (Updated Nov. 19, 2013, 3:21 a.m.) Review request for kafka. Bugs: KAFKA-1135

[jira] [Updated] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1135: - Attachment: KAFKA-1135_2013-11-18_19:20:58.patch > Code cleanup - use Json.encode() to write json

[jira] [Commented] (KAFKA-1135) Code cleanup - use Json.encode() to write json data to zk

2013-11-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826133#comment-13826133 ] Swapnil Ghike commented on KAFKA-1135: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1127) kafka and zookeeper server should start in daemon mode and log to correct position

2013-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1127: --- Resolution: Fixed Fix Version/s: 0.8.1 Assignee: Raymond Liu Status: Resolved (was