[
https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825893#comment-13825893
]
Neha Narkhede commented on KAFKA-1112:
--------------------------------------
Thanks for the patch, Jun! Overall, looks good (+1). Few minor comments that
you can address on checkin -
1. Log
- okay we need to actually recovery this log => okay we need to actually
recover this log
2. OffsetIndex
- In sanityCheck(), in one error message, we print the index file's absolute
path and in another, we print only the name. Can we standardize on one? It is
better to print the entire path since we can have more than one data
directories.
> broker can not start itself after kafka is killed with -9
> ---------------------------------------------------------
>
> Key: KAFKA-1112
> URL: https://issues.apache.org/jira/browse/KAFKA-1112
> Project: Kafka
> Issue Type: Bug
> Components: log
> Affects Versions: 0.8, 0.8.1
> Reporter: Kane Kim
> Assignee: Jay Kreps
> Priority: Critical
> Attachments: KAFKA-1112-v1.patch, KAFKA-1112-v2.patch,
> KAFKA-1112-v3.patch, KAFKA-1112-v4.patch, KAFKA-1112.out
>
>
> When I kill kafka with -9, broker cannot start itself because of corrupted
> index logs. I think kafka should try to delete/rebuild indexes itself without
> manual intervention.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
