[jira] [Updated] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-v1.patch > Kafka patch review tool > --- > >

[jira] [Closed] (KAFKA-923) Improve controller failover latency

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-923. - > Improve controller failover latency > --- > > Key: KAFKA-923 >

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765624#comment-13765624 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

Review Request 14111: (trunk) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Christopher Freeman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14111/ --- Review request for kafka and Neha Narkhede. Bugs: KAFKA-1046 https://issues

Re: Kafka patch review process

2013-09-13 Thread Neha Narkhede
Thanks for the feedback. This tool is actually designed to reduce the review overhead and make reviews less time consuming and more readable. So this is more of a contributor's workflow than a committer's workflow. I agree that this might be too much of a process to follow for one-time smallish co

Re: Kafka patch review process

2013-09-13 Thread Neha Narkhede
>> I think we may be saying the same thing. I am differentiating between regular contributors (who are likely committers) and first-time contributors. Agree with this. Once the review tool is stabilized and reviewed, will update the patch workflow wiki to reflect this distinction. Thanks, Neha

Re: Producer not distributing across all partitions

2013-09-13 Thread Neha Narkhede
Are you using Kafka 07 or 08 ? On Thu, Sep 12, 2013 at 1:56 PM, prashant amar wrote: > I created a topic with 4 partitions and for some reason the producer is > pushing only to one partition. > > This is consistently happening across all topics that I created ... > > Is there a specific config

Producer not distributing across all partitions

2013-09-13 Thread prashant amar
I created a topic with 4 partitions and for some reason the producer is pushing only to one partition. This is consistently happening across all topics that I created ... Is there a specific configuration that I need to apply to ensure that load is evenly distributed across all partitions? Grou

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 12, 2013, 9:22 p.m.) Review request for kafka. Summary (update

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 12, 2013, 9:23 p.m.) Review request for kafka. Bugs: KAFKA-105

[jira] [Updated] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-v3.patch > Kafka patch review tool > --- > >

[jira] [Updated] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-v2.patch > Kafka patch review tool > --- > >

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765908#comment-13765908 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765909#comment-13765909 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

Query : failed due to Leader not local for partition

2013-09-13 Thread Anuj Mehta
Hi I am a newbie "Kafka" user. I had 0.8 branch code and trying to run a simple producer (currently no consumer) from kafka-java-examples on *Window XP* When the producer tries to send a message I get following [2013-09-13 12:39:28,244] WARN [KafkaApi-0] Produce request with correlation id 2 fro

[jira] [Commented] (KAFKA-948) ISR list in LeaderAndISR path not updated for partitions when Broker (which is not leader) is down

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766575#comment-13766575 ] Jun Rao commented on KAFKA-948: --- Is this still happening in 0.8? > ISR list

[jira] [Updated] (KAFKA-970) ./sbt +package rebuilds the Hadoop consumer jar N times with the same output file

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-970: -- Fix Version/s: (was: 0.8) > ./sbt +package rebuilds the Hadoop consumer jar N times with the same output

[jira] [Resolved] (KAFKA-973) Messages From Producer Not being Partitioned

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-973. --- Resolution: Not A Problem > Messages From Producer Not being Partitioned > --

[jira] [Closed] (KAFKA-973) Messages From Producer Not being Partitioned

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-973. - > Messages From Producer Not being Partitioned > - > >

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-972: -- Fix Version/s: (was: 0.8) Could you describe how to reproduce this? > MetadataRequest retur

[jira] [Commented] (KAFKA-975) Leader not local for partition when partition is leader (kafka.common.NotLeaderForPartitionException)

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766567#comment-13766567 ] Jun Rao commented on KAFKA-975: --- Any error in the controller and state-change log?

[jira] [Updated] (KAFKA-1040) ConsumerConfig and ProducerConfig do "work" in the Constructor

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1040: --- Fix Version/s: 0.8.1 > ConsumerConfig and ProducerConfig do "work" in the Constructor > -

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1046: --- Fix Version/s: 0.8 > Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x > ---

[jira] [Commented] (KAFKA-1036) Unable to rename replication offset checkpoint in windows

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766549#comment-13766549 ] Jun Rao commented on KAFKA-1036: Hmm, not sure how to patch this since we close the writer

[jira] [Updated] (KAFKA-1044) change log4j to slf4j

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1044: --- Fix Version/s: 0.9 > change log4j to slf4j > -- > > Key: KAFKA-1044

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1046: --- Status: Patch Available (was: Open) > Added support for Scala 2.10 builds while maintaining compatibilit

preparing for the 0.8 final release

2013-09-13 Thread Jun Rao
Hi, Everyone, We have been stabilizing the 0.8 branch since the beta1 release. I think we are getting close to an 0.8 final release. I made an initial list of the remaining jiras that should be fixed in 0.8. https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20fixVersion%20%3D

[jira] [Commented] (KAFKA-956) High-level consumer fails to check topic metadata response for errors

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766581#comment-13766581 ] Jun Rao commented on KAFKA-956: --- This can probably be fixed as part of kafka-1030.

[jira] [Updated] (KAFKA-1027) Add documentation for system tests

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1027: --- Fix Version/s: (was: 0.8) 0.8.1 > Add documentation for system tests > ---

[VOTE] Bylaws!

2013-09-13 Thread Jay Kreps
It was pointed out to us that Apache projects should formalize their bylaws--basically how votes are done, who votes on what, and what the criteria are for voting. We have been acting informally so far and haven't really taken the time to do this. Here is a set of bylaws which I propose we adopt:

[jira] [Commented] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Christopher Freeman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766675#comment-13766675 ] Christopher Freeman commented on KAFKA-1046: Review board for an updated trunk

Re: Review Request 14111: (trunk) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14111/#review26085 --- Ship it! Looks great. Thanks a lot for you contribution! - Neha Na

[jira] [Updated] (KAFKA-946) Kafka Hadoop Consumer fails when verifying message checksum

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-946: -- Fix Version/s: 0.8 > Kafka Hadoop Consumer fails when verifying message checksum > -

[jira] [Commented] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1378#comment-1378 ] Neha Narkhede commented on KAFKA-1046: -- [~cfreeman] We are ready to take the patch on

Re: [VOTE] Bylaws!

2013-09-13 Thread Joel Koshy
+1 binding On Fri, Sep 13, 2013 at 10:00 AM, Joe Stein wrote: > +1 binding > > /*** > Joe Stein > Founder, Principal Consultant > Big Data Open Source Security LLC > http://www.stealth.ly > Twitter: @allthingshadoop

Re: [VOTE] Bylaws!

2013-09-13 Thread Joe Stein
+1 binding /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop / On Fri, Sep 13, 2013 at 12

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766639#comment-13766639 ] Neha Narkhede commented on KAFKA-972: - Is this repetitive or the metadata starts return

[jira] [Commented] (KAFKA-1038) fetch response should use empty messageset instead of null when handling errors

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766640#comment-13766640 ] Neha Narkhede commented on KAFKA-1038: -- +1 > fetch response should u

Re: [VOTE] Bylaws!

2013-09-13 Thread Neha Narkhede
Binding +1 from me. Thanks, Neha On Fri, Sep 13, 2013 at 9:53 AM, Jay Kreps wrote: > It was pointed out to us that Apache projects should formalize their > bylaws--basically how votes are done, who votes on what, and what the > criteria are for voting. We have been acting informally so far and

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Christopher Freeman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Freeman updated KAFKA-1046: --- Attachment: kafka_2_10_refactor.patch > Added support for Scala 2.10 builds while

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Christopher Freeman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Freeman updated KAFKA-1046: --- Attachment: (was: kafka_2_10_refactor.patch) > Added support for Scala 2.10 b

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26082 --- kafka-patch-review.py

Re: Query : failed due to Leader not local for partition

2013-09-13 Thread Guozhang Wang
Hi Anuj, The LeaderNotLocalException could be transient: https://cwiki.apache.org/confluence/display/KAFKA/FAQ#FAQ-WhydoIseelotsofLeadernotlocalexceptionsonthebrokerduringcontrolledshutdown%3F Guozhang On Fri, Sep 13, 2013 at 12:21 AM, Anuj Mehta wrote: > Hi > > I am a newbie "Kafka" user.

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-13 Thread Guozhang Wang
> On Sept. 10, 2013, 9:46 p.m., Joel Koshy wrote: > > Following up on the performance concerns that Neha had raised - this will > > be a significant bottleneck for tools such as the mirror-maker as the > > rebalance latency will almost certainly multiply. > > > > We could consider utilizing th

[jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1046: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patches. Checke

Re: [jira] [Updated] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Joe Stein
Thanks Chris for the patches and Neha for reviewing and committing them!!! It is great we now have support for Scala 2.10 in Kafka trunk and also 0.8 branch and without losing any existing support for anything else. /*** Joe Stein Founder, Principal Consu

Re: Producer not distributing across all partitions

2013-09-13 Thread Joe Stein
Isn't this a bug? I don't see why we would want users to have to code and generate random partition keys to randomly distributed the data to partitions, that is Kafka's job isn't it? Or if supplying a null value tell the user this is not supported (throw exception) in KeyedMessage like we do for

[jira] [Updated] (KAFKA-1041) Number of file handles increases indefinitely in producer if broker host is unresolvable

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1041: --- Fix Version/s: 0.8.1 Moving to 0.8.1 since it's not very critical > Number of file handles i

[jira] [Updated] (KAFKA-1038) fetch response should use empty messageset instead of null when handling errors

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1038: --- Fix Version/s: 0.8 > fetch response should use empty messageset instead of null when handling > errors >

[jira] [Commented] (KAFKA-1043) Time-consuming FetchRequest could block other request in the response queue

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766987#comment-13766987 ] Guozhang Wang commented on KAFKA-1043: -- One possible approach would be adding a timer

Review Request 14140: Follow up to handle ack=0 in handleError

2013-09-13 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14140/ --- Review request for kafka. Bugs: KAFKA-955 https://issues.apache.org/jira/br

[jira] [Commented] (KAFKA-955) After a leader change, messages sent with ack=0 are lost

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767054#comment-13767054 ] Guozhang Wang commented on KAFKA-955: - Created reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-955) After a leader change, messages sent with ack=0 are lost

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-955: Attachment: KAFKA-955-followup.v1.patch > After a leader change, messages sent with ack=0 are lo

Re: Review Request 14140: Follow up to handle ack=0 in handleError

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14140/#review26104 --- Ship it! Ship It! - Neha Narkhede On Sept. 13, 2013, 10:17 p.m.,

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
> On Sept. 13, 2013, 4:58 p.m., Guozhang Wang wrote: > > kafka-patch-review.py, line 43 > > > > > > If version is not specified, then v1 is used as default: I think this > > might mess up the ticket attachments from mu

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 13, 2013, 10:34 p.m.) Review request for kafka. Bugs: KAFKA-10

[jira] [Updated] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-followup.patch > Kafka patch review tool > --- > >

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767082#comment-13767082 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26108 --- Ship it! Ship It! - Sriram Subramanian On Sept. 13, 2013, 10:34

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26109 --- Might be useful to publish it widely - Sriram Subramanian On Sept

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
> On Sept. 13, 2013, 10:48 p.m., Sriram Subramanian wrote: > > Might be useful to publish it widely Makes sense. I just got pinged by Helix, they want to use the tool. Probably publishing it on github will be useful to a lot of projects. Thanks! - Neha -

[jira] [Closed] (KAFKA-1046) Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1046. > Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x >

[jira] [Commented] (KAFKA-955) After a leader change, messages sent with ack=0 are lost

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767147#comment-13767147 ] Jun Rao commented on KAFKA-955: --- Thanks for the followup patch. +1 and committed to 0.8.

[jira] [Updated] (KAFKA-1038) fetch response should use empty messageset instead of null when handling errors

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1038: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. Committed to 0.8.

[jira] [Closed] (KAFKA-1038) fetch response should use empty messageset instead of null when handling errors

2013-09-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-1038. -- > fetch response should use empty messageset instead of null when handling > errors >

Re: Review Request 14091: Patch for KAFKA-1053

2013-09-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 13, 2013, 11:33 p.m.) Review request for kafka. Bugs: KAFKA-10

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767173#comment-13767173 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-followup2.patch > Kafka patch review tool > --- >

Re: [VOTE] Bylaws!

2013-09-13 Thread Jun Rao
+1 Jun On Fri, Sep 13, 2013 at 9:53 AM, Jay Kreps wrote: > It was pointed out to us that Apache projects should formalize their > bylaws--basically how votes are done, who votes on what, and what the > criteria are for voting. We have been acting informally so far and haven't > really taken th

[jira] [Created] (KAFKA-1054) Elimiate Compilation Warnings for 0.8 Final Release

2013-09-13 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1054: Summary: Elimiate Compilation Warnings for 0.8 Final Release Key: KAFKA-1054 URL: https://issues.apache.org/jira/browse/KAFKA-1054 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-1054) Elimiate Compilation Warnings for 0.8 Final Release

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1054: - Description: Currently we have a total number of 38 warnings for source code compilation of 0.8.

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767216#comment-13767216 ] Joel Koshy commented on KAFKA-1053: --- Ran into this while following the instructions. May

[jira] [Updated] (KAFKA-1054) Elimiate Compilation Warnings for 0.8 Final Release

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1054: - Description: Currently we have a total number of 38 warnings for source code compilation of 0.8.

[jira] [Commented] (KAFKA-1054) Elimiate Compilation Warnings for 0.8 Final Release

2013-09-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767218#comment-13767218 ] Guozhang Wang commented on KAFKA-1054: -- I am not sure what to do with 3) but: For 1)

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767225#comment-13767225 ] Joel Koshy commented on KAFKA-1053: --- Probably because I did both yum install python-setu

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

2013-09-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767234#comment-13767234 ] Neha Narkhede commented on KAFKA-1053: -- Ya, I think the post review page is a bit con

Random Partitioning Issue

2013-09-13 Thread Joe Stein
First, let me apologize for not realizing/noticing this until today. One reason I left my last company was not being paid to work on Kafka nor being able to afford any time for a while to work on it. Now in my new gig (just wrapped up my first week, woo hoo) while I am still not "paid to work on K