[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625222#comment-13625222 ] Swapnil Ghike commented on KAFKA-826: - Thanks, the unit tests were ok. But while trying

[jira] [Comment Edited] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625222#comment-13625222 ] Swapnil Ghike edited comment on KAFKA-826 at 4/8/13 8:04 AM: - T

[jira] [Created] (KAFKA-855) Ant+Ivy build for Kafka

2013-04-08 Thread David Arthur (JIRA)
David Arthur created KAFKA-855: -- Summary: Ant+Ivy build for Kafka Key: KAFKA-855 URL: https://issues.apache.org/jira/browse/KAFKA-855 Project: Kafka Issue Type: Improvement Affects Versions:

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread David Arthur
Jun, I have opened a ticket targeting 0.9 https://issues.apache.org/jira/browse/KAFKA-855 -David On 4/8/13 1:06 AM, Jun Rao wrote: David, We'd be open to a new build tool if SBT is deemed too hard to use. We can revisit this post 0.8. Do you want to open a jira to track this? Thanks, Jun

[jira] [Updated] (KAFKA-855) Ant+Ivy build for Kafka

2013-04-08 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-855: --- Attachment: 0003-Parameterize-scala-version-add-offline-mode.patch 0002-Tests-all-passi

[jira] [Created] (KAFKA-856) Correlation id for OffsetFetch request (#2) always responds with 0

2013-04-08 Thread Milosz Tanski (JIRA)
Milosz Tanski created KAFKA-856: --- Summary: Correlation id for OffsetFetch request (#2) always responds with 0 Key: KAFKA-856 URL: https://issues.apache.org/jira/browse/KAFKA-856 Project: Kafka

Incubator PMC/Board report for Apr 2013 ([ppmc])

2013-04-08 Thread Marvin
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 17 April 2013, 10:30:00:00 PST. The report for your podling wil

[jira] [Commented] (KAFKA-850) add an option to show under replicated partitions in list topic command

2013-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625512#comment-13625512 ] Neha Narkhede commented on KAFKA-850: - Thanks for the patch. Minor comments - ListTopi

[jira] [Commented] (KAFKA-850) add an option to show under replicated partitions in list topic command

2013-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625513#comment-13625513 ] Neha Narkhede commented on KAFKA-850: - Also +1 once those comments are addressed.

[jira] [Commented] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

2013-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625515#comment-13625515 ] Neha Narkhede commented on KAFKA-852: - Thanks for the patch, David. However, I'm not ab

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625520#comment-13625520 ] Neha Narkhede commented on KAFKA-854: - Scott, I think that is a remainder that we forg

[jira] [Comment Edited] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

2013-04-08 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625515#comment-13625515 ] Neha Narkhede edited comment on KAFKA-852 at 4/8/13 4:40 PM: - T

[jira] [Updated] (KAFKA-850) add an option to show under replicated partitions in list topic command

2013-04-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-850: -- Resolution: Fixed Fix Version/s: 0.8 Status: Resolved (was: Patch Available) Thanks for the r

[jira] [Updated] (KAFKA-856) Correlation id for OffsetFetch request (#2) always responds with 0

2013-04-08 Thread Milosz Tanski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milosz Tanski updated KAFKA-856: Status: Patch Available (was: Open) I have a patch to fix this > Correlation id fo

[jira] [Updated] (KAFKA-856) Correlation id for OffsetFetch request (#2) always responds with 0

2013-04-08 Thread Milosz Tanski (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Milosz Tanski updated KAFKA-856: Attachment: KAFKA-856.patch The mentioned patch. > Correlation id for OffsetFetch r

[jira] [Updated] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

2013-04-08 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-852: --- Attachment: KAFKA-852.diff > Remove clientId from OffsetFetchResponse and OffsetCommitResponse > -

[jira] [Commented] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

2013-04-08 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625576#comment-13625576 ] David Arthur commented on KAFKA-852: @Neha, I attached a diff created using git-diff. T

[jira] [Updated] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Dragos Manolescu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dragos Manolescu updated KAFKA-826: --- Attachment: (was: kafka-fix-for-826-complete.patch) > Make Kafka 0.8 depend on metrics

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625601#comment-13625601 ] Scott Carey commented on KAFKA-854: --- The problem is I'm an SBT neophyte, and I keep think

[jira] [Updated] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Dragos Manolescu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dragos Manolescu updated KAFKA-826: --- Attachment: kafka-fix-for-826-complete.patch Hmm, it looks like for some reason the metrics JA

[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625652#comment-13625652 ] Scott Carey commented on KAFKA-854: --- {quote} While you're at it you could also upgrade Ja

[jira] Subscription: outstanding kafka patches

2013-04-08 Thread jira
Issue Subscription Filter: outstanding kafka patches (59 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-856 Correlation id for OffsetFetch request (#2) always responds with 0 https://issues.apache.org/jira/browse/KAFKA-8

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
My first reaction to looking at the current build was that I could do a lot better with Maven and I'd get a lot of free stuff with that (dependency:tree, versions:display-dependency-updates), except that cross scala versions would be uglier. Modularization is trivial with maven (the stuff outside

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread David Arthur
Ant and Ivy also bring in lots of free stuff as well as the flexibility to do non-standard things It seems that SBT is a moving target (as is Scala itself, being such a new tech), and keeping up with SBT changes and people's plugins hosted on GitHub sounds like a pain. Maven and Ant/Ivy are ma

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Jay Kreps
I think the biggest problem is that there isn't clear ownership of the build stuff we have. SBT is probably fine if you know it well. Ant and maven are probably the same. The problem is that none of the committers seem to know SBT well that that is a big barrier for getting basic stuff like a good

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread David Arthur
Targeting multiple Scala versions is easy with Ant/Ivy and I believe is possible in Maven. Incremental compilation is available through some IDEs: Eclipse has a plugin from Typesafe that does incremental build: http://typesafe.com/technology/scala-ide Intellij supports it by using SBT: http://

Re: Kafka and Scala versions

2013-04-08 Thread Scott Carey
We are on 2.10 already. String interpolation (2.10), Value classes (2.10), parallel collections (2.9), are too good to give up. Akka actors, futures, and promises being part of the distribution are nice as well. The compiler is faster, and emits a lot of warnings in Kafka code that could be bugs

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
Gradle is also gaining a lot of popularity, and has a good deal of Scala support. I don't know if it has incremental compilation. The maven scala plugin at one time had incremental compilation, I don't know what state that is in now. I'm giving learning enough SBT a shot right now to clean the c

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread Scott Carey
Let me google that for myself: Gradle has incremental scala compilation: http://www.gradle.org/docs/current/userguide/scala_plugin.html Maven does too: http://davidb.github.io/scala-maven-plugin/example_incremental.html So I suspect it could be solved with Ant. Maven and Gradle both support call

Re: Thoughts on using Ant+Ivy for the build?

2013-04-08 Thread David Arthur
Yes Ant supports it too since scalac supports it. Most likely Maven and Gradle are using scalac or SBT under the hood (unless they have written their own compilers - unlikely). However, from what I've read when researching the Ant build, these scalac options (-make:transitive -dependencyfile)

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626135#comment-13626135 ] Scott Carey commented on KAFKA-826: --- Can a committer look at this? This would be great t

[jira] [Updated] (KAFKA-854) Upgrade dependencies for 0.8

2013-04-08 Thread Scott Carey (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Carey updated KAFKA-854: -- Attachment: KAFKA-854.patch Cleans up dependencies and SBT build in general (~350 lines fewer than prior

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Matt Christiansen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626304#comment-13626304 ] Matt Christiansen commented on KAFKA-826: - I made my own branch and applyed this pa