[ 
https://issues.apache.org/jira/browse/KAFKA-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625512#comment-13625512
 ] 

Neha Narkhede commented on KAFKA-850:
-------------------------------------

Thanks for the patch. Minor comments -

ListTopicCommand-
1.1 Typo in ListTopicCommand -> "partiitons"
1.2 Why do we print the topic separately like this ? It becomes quite 
unwieldily to parse the output where one line just has topic, but not the 
partitions and replicas. Also, we print the topic anyways with the rest of the 
partition and replica info. So I think we can remove this
        if (!reportUnderReplicatedPartitions && !reportUnavailablePartitions)
          println("topic: " + topic)


                
> add an option to show under replicated partitions in list topic command
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-850
>                 URL: https://issues.apache.org/jira/browse/KAFKA-850
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>         Attachments: kafka-850.patch, kafka-850_v2.patch, kafka-850_v3.patch
>
>
> For debugging purpose, it's very important to be able to find out the under 
> replicated partitions quickly. List topic command is a good place to add this 
> feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to