Re: 0.8 branch, test failing? = AsyncProducerTest.testProducerQueueSize

2013-01-20 Thread Neha Narkhede
Joe, Please can you enable DEBUG logging for the test, that will get you the details of the failure. You will need to modify the log4j.properties file in core/src/test/resources Thanks, Neha On Sat, Jan 19, 2013 at 8:25 PM, Joe Stein wrote: > Hey, I was reviewing the 0.12.1 SBT upgrade patch

[jira] [Closed] (KAFKA-698) broker may expose uncommitted data to a consumer

2013-01-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-698. --- > broker may expose uncommitted data to a consumer >

[jira] [Commented] (KAFKA-705) Controlled shutdown doesn't seem to work on more than one broker in a cluster

2013-01-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558341#comment-13558341 ] Neha Narkhede commented on KAFKA-705: - +1 on the fix. And there is a problem with the s

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558420#comment-13558420 ] Jun Rao commented on KAFKA-671: --- Thanks for the patch. I agree with Neha that ProducerRequest

[jira] [Commented] (KAFKA-696) Fix toString() API for all requests to make logging easier to read

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558439#comment-13558439 ] Jun Rao commented on KAFKA-696: --- Thanks for the patch. Some comments: 1. RequestOrResponse.h

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558448#comment-13558448 ] Jun Rao commented on KAFKA-671: --- Thinking about this a bit more. There is another approach. I

[jira] [Updated] (KAFKA-631) Implement log compaction

2013-01-20 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-631: Attachment: KAFKA-631-v2.patch New patch, only minor changes: 1. Rebased against trunk at 9ee795ac563c3ce4c4

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-01-20 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558462#comment-13558462 ] Sriram Subramanian commented on KAFKA-671: -- I think to do this right we should lim

[jira] [Commented] (KAFKA-707) Improve error message in the producer when sending data to a partition without an active leader

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558474#comment-13558474 ] Jun Rao commented on KAFKA-707: --- +1 for the patch. > Improve error message i

Re: 0.8 branch, test failing? = AsyncProducerTest.testProducerQueueSize

2013-01-20 Thread Joe Stein
found the culprit looks like https://issues.apache.org/jira/browse/KAFKA-709 the fix I think is best to just update the AsyncProducerTest case for if someone changes the new default value to something like 0 so it goes to offer instead of put adding the line props.put("queue.enqueue.timeout.ms",

[jira] [Commented] (KAFKA-709) Default queue.enqueue.timeout.ms to -1

2013-01-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558500#comment-13558500 ] Joe Stein commented on KAFKA-709: - found a test failing related to this the fix I think is

[jira] [Commented] (KAFKA-139) cross-compile multiple Scala versions

2013-01-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558512#comment-13558512 ] Joe Stein commented on KAFKA-139: - FYI I have been reviewing git remote add dchenbecker g

[jira] [Updated] (KAFKA-139) cross-compile multiple Scala versions and upgrade to SBT 0.12.1

2013-01-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-139: Summary: cross-compile multiple Scala versions and upgrade to SBT 0.12.1 (was: cross-compile multiple Scala

[jira] [Updated] (KAFKA-134) Upgrade Kafka to sbt 0.11.3

2013-01-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-134: Status: Open (was: Patch Available) all of the work has moved into KAFKA-139 to cross compile and upgrade t

[jira] [Resolved] (KAFKA-134) Upgrade Kafka to sbt 0.11.3

2013-01-20 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-134. - Resolution: Duplicate Fix Version/s: 0.8 > Upgrade Kafka to sbt 0.11.3 > --

[jira] [Updated] (KAFKA-710) Some arguments are always set to default in ProducerPerformance

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-710: -- Resolution: Fixed Fix Version/s: 0.8 Assignee: John Fung Status: Resolved (was: Patch

[jira] [Commented] (KAFKA-139) cross-compile multiple Scala versions and upgrade to SBT 0.12.1

2013-01-20 Thread derek (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558550#comment-13558550 ] derek commented on KAFKA-139: - Joe, that's great! Let me know if you run into any issues beyond