[ 
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558420#comment-13558420
 ] 

Jun Rao commented on KAFKA-671:
-------------------------------

Thanks for the patch. I agree with Neha that ProducerRequest.resetData() seems 
a bit hacky. Another thing is that currently, we log the request object in 
trace in RequestChannel.Request when processing the response. Resetting the 
data in the produce request may break the logic there.

Maybe we should test it out and see if this is really a problem. It's true that 
there could be many producers. However, it may take some time for them to 
generate 1GB of data.
                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to