Re: Should InvalidTopicException be called IllegalTopicException

2017-02-17 Thread Colin McCabe
on or have a one > that clearly mentions the name InvalidTopicNameException. However I guess > the first option would be the easiest. > > > Thanks, > > Cosmin > > > > From: Cosmin Lehene > Sent: Thursday, February 16, 2017 4:29

Re: Should InvalidTopicException be called IllegalTopicException

2017-02-16 Thread Cosmin Lehene
From: Cosmin Lehene Sent: Thursday, February 16, 2017 4:29:14 PM To: dev@kafka.apache.org Subject: Should InvalidTopicException be called IllegalTopicException It's a bit confusing when trying to understand what's the difference between UnknownTopicOrPartitio

Should InvalidTopicException be called IllegalTopicException

2017-02-16 Thread Cosmin Lehene
It's a bit confusing when trying to understand what's the difference between UnknownTopicOrPartitionException (retriable) and InvalidTopicException (non-retriable). Looking through the code to figure out what's an invalid topic I see most tests that throw it describe it as "illegal". This is a