Hmm. I'm not sure that "illegal" is that different from "invalid" semantically. If an argument is illegal for a given function, you could also say that argument is invalid for that function. Also, changing exception names could be frustrating to users from a compatibility perspective. Perhaps some better documentation could help here?
best, Colin On Thu, Feb 16, 2017, at 16:32, Cosmin Lehene wrote: > Wow, I managed to send two incomplete messages thanks to the new mac > touchbar :) > > > I was suggesting either renaming to IllegalTopicException or have a one > that clearly mentions the name InvalidTopicNameException. However I guess > the first option would be the easiest. > > > Thanks, > > Cosmin > > > ________________________________ > From: Cosmin Lehene > Sent: Thursday, February 16, 2017 4:29:14 PM > To: dev@kafka.apache.org > Subject: Should InvalidTopicException be called IllegalTopicException > > > It's a bit confusing when trying to understand what's the difference > between UnknownTopicOrPartitionException (retriable) and > InvalidTopicException (non-retriable). > > > Looking through the code to figure out what's an invalid topic I see most > tests that throw it describe it as "illegal". This is also the case when > trying to write to an internal topic. > > > While a longer discussion around having an invalid topic _name >
