Re: Review Request 37357: Upgrade LZ4 to version 1.3 to avoid crashing with IBM Java 7

2015-08-11 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37357/#review94979 --- Changes look good. It seems like there quite a few changes in the up

Re: Review Request 37357: Upgrade LZ4 to version 1.3 to avoid crashing with IBM Java 7

2015-08-11 Thread Rajini Sivaram
> On Aug. 11, 2015, 3:29 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockInputStream.java, > > line 177 > > > > > > Why not use `SafeUtils`? The implementation of `Unsa

Re: Review Request 37357: Upgrade LZ4 to version 1.3 to avoid crashing with IBM Java 7

2015-08-11 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37357/ --- (Updated Aug. 11, 2015, 6:56 p.m.) Review request for kafka. Bugs: KAFKA-2421

Re: Review Request 37357: Upgrade LZ4 to version 1.3 to avoid crashing with IBM Java 7

2015-08-11 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37357/#review94916 --- clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockI

Review Request 37357: Upgrade LZ4 to version 1.3 to avoid crashing with IBM Java 7

2015-08-11 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37357/ --- Review request for kafka. Bugs: KAFKA-2421 https://issues.apache.org/jira/b