----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37357/#review94916 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockInputStream.java (line 177) <https://reviews.apache.org/r/37357/#comment149627> Why not use `SafeUtils`? The implementation of `UnsafeUtils` just calls that, right? `public static void checkRange(byte[] buf, int off, int len) { SafeUtils.checkRange(buf, off, len); } ` https://github.com/jpountz/lz4-java/blob/master/src/java-unsafe/net/jpountz/util/UnsafeUtils.java#L60 clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockOutputStream.java (line 183) <https://reviews.apache.org/r/37357/#comment149628> Same as above. - Ismael Juma On Aug. 11, 2015, 3:17 p.m., Rajini Sivaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37357/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 3:17 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2421 > https://issues.apache.org/jira/browse/KAFKA-2421 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-2421: Upgrade to LZ4 version 1.3 and update reference to > Utils method that was moved to UnsafeUtils > > > Diffs > ----- > > build.gradle 1b67e628c2fca897177c12b6afad9a8700fffd1f > > clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockInputStream.java > f480da2ae0992855cc860e1ce5cbd11ecfca7bee > > clients/src/main/java/org/apache/kafka/common/record/KafkaLZ4BlockOutputStream.java > 6a2231f4775771932c36df362c88aead3189b7b8 > > Diff: https://reviews.apache.org/r/37357/diff/ > > > Testing > ------- > > > Thanks, > > Rajini Sivaram > >
