Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > > > > > Sorry for being late to the party (I have bee

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93351 --- Ship it! Ship It! - Guozhang Wang On July 28, 2015, 4:17 p.m., A

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > > > > > Sorry for being late to the party (I have bee

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > > > > > Sorry for being late to the party (I have bee

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > > > > > Sorry for being late to the party (I have bee

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:07 p.m., Edward Ribeiro wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 87 > > > > > > Sorry for being late to the party (I have bee

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review9 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/S

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93321 --- Ship it! Ship It! - Jason Gustafson On July 28, 2015, 4:17 p.m.,

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93306 --- Ship it! Code change looks good. Not very familiar with the tests,

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 8:16 a.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java, > > line 86 > > > > > > A minor optimisation is to use `ArrayList` here

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ --- (Updated July 28, 2015, 4:17 p.m.) Review request for kafka. Bugs: KAFKA-2381

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93256 --- clients/src/main/java/org/apache/kafka/clients/consumer/internals/S

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 1:15 a.m., Aditya Auradkar wrote: > > core/src/test/scala/integration/kafka/api/ConsumerTest.scala, line 233 > > > > > > consider closing this in a finally. A failing test can cause incorrect > >

Re: Review Request 36871: Patch for KAFKA-2381

> On July 28, 2015, 1:11 a.m., Jason Gustafson wrote: > > Ouch. Hard to believe this wasn't caught yet. It is. Thanks for the review. Addressed your concern. - Ashish --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ --- (Updated July 28, 2015, 4:59 a.m.) Review request for kafka. Bugs: KAFKA-2381

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ --- (Updated July 28, 2015, 4:56 a.m.) Review request for kafka. Bugs: KAFKA-2381

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93215 --- core/src/test/scala/integration/kafka/api/ConsumerTest.scala (line

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/#review93213 --- Ouch. Hard to believe this wasn't caught yet. core/src/test/scala/

Re: Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ --- (Updated July 28, 2015, 12:56 a.m.) Review request for kafka. Bugs: KAFKA-238

Review Request 36871: Patch for KAFKA-2381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ --- Review request for kafka. Bugs: KAFKA-2381 https://issues.apache.org/jira/b