----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36871/ -----------------------------------------------------------
(Updated July 28, 2015, 4:17 p.m.) Review request for kafka. Bugs: KAFKA-2381 https://issues.apache.org/jira/browse/KAFKA-2381 Repository: kafka Description (updated) ------- Address review comment Move closing of consumer to finally Add a more specific unit test KAFKA-2381: Possible ConcurrentModificationException while unsubscribing from a topic in new consumer Diffs (updated) ----- clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java 4d9a425201115a66b457b58d670992b279091f5a clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java 319751c374ccdc7e7d7d74bcd01bc279b1bdb26e core/src/test/scala/integration/kafka/api/ConsumerTest.scala 3eb5f95731a3f06f662b334ab2b3d0ad7fa9e1ca Diff: https://reviews.apache.org/r/36871/diff/ Testing ------- Thanks, Ashish Singh