Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/ --- (Updated Aug. 4, 2015, 1:24 a.m.) Review request for kafka. Bugs: KAFKA-2332

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
> On Aug. 4, 2015, 12:36 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, line > > 25 > > > > > > unused import Thanks for the catch. - Dong

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/ --- (Updated Aug. 4, 2015, 1:23 a.m.) Review request for kafka. Bugs: KAFKA-2332

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/#review93833 --- Ship it! core/src/main/scala/kafka/consumer/FetchRequestAndRespons

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-02 Thread Dong Lin
> On July 23, 2015, 5:56 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala, line 138 > > > > > > same comment about null fetchRequestAndResponseStats.getFetchRequestAndResponse

Re: Review Request 36722: Patch for KAFKA-2332

2015-07-23 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/#review92778 --- core/src/main/scala/kafka/consumer/SimpleConsumer.scala (line 138)

Re: Review Request 36722: Patch for KAFKA-2332

2015-07-23 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/#review92765 --- LGTM. It seems the Quota patch hasn't been checked in. Let's hold ba

Review Request 36722: Patch for KAFKA-2332

2015-07-23 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/ --- Review request for kafka. Bugs: KAFKA-2332 https://issues.apache.org/jira/b