----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/#review92778 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/SimpleConsumer.scala (line 138) <https://reviews.apache.org/r/36722/#comment147021> same comment about null core/src/main/scala/kafka/producer/SyncProducer.scala (line 109) <https://reviews.apache.org/r/36722/#comment147020> can the getProducerStats().throttleTimeHist be null? What if we simply duplicate the sensors we are adding in 2136 for the new producer and consumer? - Aditya Auradkar On July 23, 2015, 7:12 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36722/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 7:12 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2332 > https://issues.apache.org/jira/browse/KAFKA-2332 > > > Repository: kafka > > > Description > ------- > > KAFKA-2332; Add quota metrics to old producer and consumer > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala > 3df55e13001cef31ee662cc713b99baf8ab4ce0f > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > 7ebc0405d1f309bed9943e7116051d1d8276f200 > core/src/main/scala/kafka/producer/ProducerRequestStats.scala > 026e93a2f1dcc0e6380fad509dc98b0cc6469a7a > core/src/main/scala/kafka/producer/SyncProducer.scala > dcee50113b1b1e062a56ab0f63ac6bb175be6b75 > > Diff: https://reviews.apache.org/r/36722/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
