Re: Review Request 36368: Patch for KAFKA-1740

2015-07-09 Thread Jason Gustafson
> On July 9, 2015, 8:40 p.m., Guozhang Wang wrote: > > Could you add some unit test for this fix? Done. The test case depends on timing like the other response tests, but it should test what we want most of the time and succeed even if there is an unexpected delay in execution. > On July 9,

Re: Review Request 36368: Patch for KAFKA-1740

2015-07-09 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36368/ --- (Updated July 9, 2015, 9:41 p.m.) Review request for kafka. Bugs: KAFKA-1740

Re: Review Request 36368: Patch for KAFKA-1740

2015-07-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36368/#review91187 --- Could you add some unit test for this fix? core/src/main/scala/kaf

Re: Review Request 36368: Patch for KAFKA-1740

2015-07-09 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36368/#review91184 --- Ship it! Ship It! - Onur Karaman On July 9, 2015, 8:23 p.m., Jas

Review Request 36368: Patch for KAFKA-1740

2015-07-09 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36368/ --- Review request for kafka. Bugs: KAFKA-1740 https://issues.apache.org/jira/b