----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36368/#review91187 -----------------------------------------------------------
Could you add some unit test for this fix? core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala (line 358) <https://reviews.apache.org/r/36368/#comment144470> I feel it is helpful to add add the new members list in this info entry as well. I can do that upon checkin if people are OK with it? - Guozhang Wang On July 9, 2015, 8:23 p.m., Jason Gustafson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36368/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 8:23 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1740 > https://issues.apache.org/jira/browse/KAFKA-1740 > > > Repository: kafka > > > Description > ------- > > KAFKA-1740; heartbeat should return illegal generation if rebalancing > > > Diffs > ----- > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala > 476973b2c551db5be3f1c54f94990f0dd15ff65e > > Diff: https://reviews.apache.org/r/36368/diff/ > > > Testing > ------- > > > Thanks, > > Jason Gustafson > >
