Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review93346 --- Ship it! Ship It! - Guozhang Wang On July 2, 2015, 4:04 p.m., As

Re: Review Request 35850: Patch for KAFKA-2301

> On July 2, 2015, 8:01 a.m., Ewen Cheslack-Postava wrote: > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala, line 110 > > > > > > Since this is a warning, can we just use warn() instead of info()? > > O

Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- (Updated July 2, 2015, 4:04 p.m.) Review request for kafka. Bugs: KAFKA-2301

Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review90199 --- core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala (line 1

Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- (Updated July 2, 2015, 12:46 a.m.) Review request for kafka. Bugs: KAFKA-2301

Re: Review Request 35850: Patch for KAFKA-2301

> On June 25, 2015, 1:06 a.m., Ewen Cheslack-Postava wrote: > > Is this what was intended by "deprecate"? I'm not sure there's been serious > > discussion about this yet, but this doesn't really deprecate the command in > > a compatible way -- just changing to ConsumerGroupCommand requires chan

Re: Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review89301 --- Is this what was intended by "deprecate"? I'm not sure there's been

Review Request 35850: Patch for KAFKA-2301

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- Review request for kafka. Bugs: KAFKA-2301 https://issues.apache.org/jira/b