> On June 25, 2015, 1:06 a.m., Ewen Cheslack-Postava wrote: > > Is this what was intended by "deprecate"? I'm not sure there's been serious > > discussion about this yet, but this doesn't really deprecate the command in > > a compatible way -- just changing to ConsumerGroupCommand requires changing > > command lines that previously would have worked (e.g., > > ./bin/kafka-consumer-groups.sh --zookeeper localhost:2181 --group foo will > > now output "Command must include exactly one action: --list, --describe, > > --delete"). Also, I'm not sure removing the bat file entirely is ok -- > > shouldn't that have basically the same change as the sh file?
Ewen, thanks for the review. Even I have doubts regarding dropping the tool right away, but I thought during KIP discussion this is what we decided. I will be happy if we just put a warning for now and drop the tool in 1.x release? Let me know your thoughts. We can also raise this in next KIP hangout, which is tomorrow :) - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review89301 ----------------------------------------------------------- On June 24, 2015, 10:10 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35850/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 10:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2301 > https://issues.apache.org/jira/browse/KAFKA-2301 > > > Repository: kafka > > > Description > ------- > > KAFKA-2301: Deprecate ConsumerOffsetChecker > > > Diffs > ----- > > bin/kafka-consumer-offset-checker.sh > c275f7ef6975c3e1226c9b286d64ad55a67b0a8b > bin/windows/kafka-consumer-offset-checker.bat > b6967c49609c3560786921d54e9df50d70c68713 > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > 3d52f62c88a509a655cf1df6232b738c25fa9b69 > system_test/broker_failure/config/log4j.properties > 23ece9bb5b3d521bb692870bc929865f68caabe0 > > Diff: https://reviews.apache.org/r/35850/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
