Re: Review Request 34766: Patch for KAFKA-2229

2015-09-19 Thread Andrii Biletskyi
> On Сер. 10, 2015, 4:56 після полудня, Grant Henke wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 81 > > > > > > Should these new errors be added to kafka.common.ErrorMapping.scala?

Re: Review Request 34766: Patch for KAFKA-2229

2015-09-12 Thread Andrii Biletskyi
> On Сер. 14, 2015, 3:48 до полудня, Grant Henke wrote: > > core/src/main/scala/kafka/server/TopicCommandHelper.scala, lines 146-153 > > > > > > This logic is fairly complex and difficult to track. I am not sure the >

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-13 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review95376 --- core/src/main/scala/kafka/server/TopicCommandHelper.scala (line 57)

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
> On Aug. 10, 2015, 5:01 p.m., Grant Henke wrote: > > core/src/main/scala/kafka/server/TopicCommandHelper.scala, line 35 > > > > > > A lot of this code/functionality exists in kafka.admin.TopicCommand. Is > > this dupl

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review94759 --- core/src/main/scala/kafka/server/TopicCommandHelper.scala (line 35)

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review94756 --- clients/src/main/java/org/apache/kafka/common/protocol/Errors.java

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
> On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote: > > My apologies for not looking at this sooner, or suggesting this sooner. > > Given that this code change and scope is fairly large, would it be too much > > work to break out the patches & reviews by each new protocol message? Then > > revie

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Ismael Juma
> On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote: > > My apologies for not looking at this sooner, or suggesting this sooner. > > Given that this code change and scope is fairly large, would it be too much > > work to break out the patches & reviews by each new protocol message? Then > > revie

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Grant Henke
> On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote: > > My apologies for not looking at this sooner, or suggesting this sooner. > > Given that this code change and scope is fairly large, would it be too much > > work to break out the patches & reviews by each new protocol message? Then > > revie

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Andrii Biletskyi
> On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote: > > My apologies for not looking at this sooner, or suggesting this sooner. > > Given that this code change and scope is fairly large, would it be too much > > work to break out the patches & reviews by each new protocol message? Then > > revie

Re: Review Request 34766: Patch for KAFKA-2229

2015-08-10 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review94749 --- My apologies for not looking at this sooner, or suggesting this soon

Re: Review Request 34766: Patch for KAFKA-2229

2015-06-30 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/ --- (Updated June 30, 2015, 1:59 p.m.) Review request for kafka. Bugs: KAFKA-2229

Review Request 34766: Patch for KAFKA-2229

2015-05-28 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/ --- Review request for kafka. Bugs: KAFKA-2229 https://issues.apache.org/jira/b