> On Сер. 10, 2015, 4:56 після полудня, Grant Henke wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 81 > > <https://reviews.apache.org/r/34766/diff/2/?file=995945#file995945line81> > > > > Should these new errors be added to kafka.common.ErrorMapping.scala?
As I understand - no. There was a discussion in mailing list about moving from scala+java request objects to java-only classes (which server and client code should use). These suggestions were also applicable for all other objects used in client-server communication, like Errors which is a counterpart for ErrorMapping. > On Сер. 10, 2015, 4:56 після полудня, Grant Henke wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java, line 92 > > <https://reviews.apache.org/r/34766/diff/2/?file=995945#file995945line92> > > > > Looks like copy paste error in exception message. Thx, fixed in PR. > On Сер. 10, 2015, 4:56 після полудня, Grant Henke wrote: > > core/src/main/scala/kafka/common/InvalidReplicaAssignmentException.scala, > > line 20 > > <https://reviews.apache.org/r/34766/diff/2/?file=995958#file995958line20> > > > > Is there a time where we would want to pass through a throwable? (Same > > for the other Exceptions added) Not sure, this was just to follow a convention - other error classes have the same constructor methods. > On Сер. 10, 2015, 4:56 після полудня, Grant Henke wrote: > > core/src/main/scala/kafka/common/InvalidTopicConfigurationException.scala, > > line 22 > > <https://reviews.apache.org/r/34766/diff/2/?file=995960#file995960line22> > > > > Is this needed? Should we always pass some message? (Same for the other > > exceptions added? Same as above. - Andrii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34766/#review94756 ----------------------------------------------------------- On Червень 30, 2015, 1:59 після полудня, Andrii Biletskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34766/ > ----------------------------------------------------------- > > (Updated Червень 30, 2015, 1:59 після полудня) > > > Review request for kafka. > > > Bugs: KAFKA-2229 > https://issues.apache.org/jira/browse/KAFKA-2229 > > > Repository: kafka > > > Description > ------- > > KIP-4 Phase 1 Rebase > > > Diffs > ----- > > checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03 > clients/src/main/java/org/apache/kafka/common/ConfigEntry.java PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/PartitionReplicaAssignment.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/TopicConfigInfo.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java > b39e9bb53dd51f1ce931691e23aabc9ebaebf1e7 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 5b898c8f8ad5d0469f469b600c4b2eb13d1fc662 > clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java > 3dc8b015afd2347a41c9a9dbc02b8e367da5f75f > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java > 5d3d52859587ce0981d702f04042b0f6e1bc3704 > > clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicResponse.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicResponse.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicRequest.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicResponse.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java > 8b2aca85fa738180e5420985fddc39a4bf9681ea > core/src/main/scala/kafka/admin/AdminUtils.scala > f06edf41c732a7b794e496d0048b0ce6f897e72b > core/src/main/scala/kafka/api/RequestKeys.scala > 155cb650e9cffe2c950326cfc25b1480cda819db > core/src/main/scala/kafka/common/InvalidPartitionsException.scala > PRE-CREATION > core/src/main/scala/kafka/common/InvalidReplicaAssignmentException.scala > PRE-CREATION > core/src/main/scala/kafka/common/InvalidReplicationFactorException.scala > PRE-CREATION > core/src/main/scala/kafka/common/InvalidTopicConfigurationException.scala > PRE-CREATION > > core/src/main/scala/kafka/common/ReassignPartitionsInProgressException.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaApis.scala > ad6f05807c61c971e5e60d24bc0c87e989115961 > core/src/main/scala/kafka/server/TopicCommandHelper.scala PRE-CREATION > core/src/test/scala/unit/kafka/admin/AdminTest.scala > 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 > core/src/test/scala/unit/kafka/server/TopicCommandHelperTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/34766/diff/ > > > Testing > ------- > > > Thanks, > > Andrii Biletskyi > >
