Re: Review Request 34397: Patch for KAFKA-1374

2015-05-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34397/#review84545 --- Ship it! Assuming some integration tests will be added in the follo

Re: Review Request 34397: Patch for KAFKA-1374

2015-05-19 Thread Joel Koshy
> On May 19, 2015, 9:41 p.m., Guozhang Wang wrote: > > About duplicating the compression logic, one way would be: > > > > 1. Add the following functions in ByteBufferMessageSet as: > > > > fill(buffer: ByteBuffer, compressionCodec: CompressionCodec, messages: > > MessageAndOffset*): Int > > >

Re: Review Request 34397: Patch for KAFKA-1374

2015-05-19 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34397/ --- (Updated May 20, 2015, 12:20 a.m.) Review request for kafka. Bugs: KAFKA-1374

Re: Review Request 34397: Patch for KAFKA-1374

2015-05-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34397/#review84390 --- About duplicating the compression logic, one way would be: 1. Add t

Review Request 34397: Patch for KAFKA-1374

2015-05-19 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34397/ --- Review request for kafka. Bugs: KAFKA-1374 https://issues.apache.org/jira/b