----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34397/#review84545 -----------------------------------------------------------
Ship it! Assuming some integration tests will be added in the follow-up patches. - Guozhang Wang On May 20, 2015, 12:20 a.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34397/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 12:20 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1374 > https://issues.apache.org/jira/browse/KAFKA-1374 > > > Repository: kafka > > > Description > ------- > > Remove no-compression constraint for compacted topics > > > Fix log cleaner integration test > > > Incorporate edits from latest patch > > > More minor edits > > > Incorporate Guozhang's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > abea8b251895a5cc0788c6e25b112a2935a3f631 > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 9dfe914991aaf82162e5e300c587c794555d5fd0 > core/src/test/scala/kafka/tools/TestLogCleaning.scala > 844589427cb9337acd89a5239a98b811ee58118e > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 3b5aa9dc3b7ac5893c1d281ae1326be0e9ed8aad > core/src/test/scala/unit/kafka/log/LogTest.scala > 76d3bfd378f32fd2b216b3ebdec86e2070491924 > > Diff: https://reviews.apache.org/r/34397/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
