Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/ --- (Updated May 28, 2015, 12:31 a.m.) Review request for kafka. Bugs: KAFKA-2191

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/ --- (Updated May 28, 2015, 12:28 a.m.) Review request for kafka. Bugs: KAFKA-2191

Re: Review Request 34170: Patch for KAFKA-2191

> On May 19, 2015, 5:14 p.m., Jay Kreps wrote: > > Oh sure. Let me look through your patch. Thank you. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review84341 -

Re: Review Request 34170: Patch for KAFKA-2191

> On May 19, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 46 > > > > > > Not sure if I grok why we need this while loop. Take a look at th

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review84341 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Sampled

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/ --- (Updated May 14, 2015, 7:34 a.m.) Review request for kafka. Bugs: KAFKA-2191

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 11:50 p.m., Aditya Auradkar wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 45 > > > > > > I think this is a good catch. > > > > Just so I u

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review83687 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Sampled

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line > > 62 > > > > > > Is this actually right? I agree you'll get discontinuities as the > > m

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/ --- (Updated May 13, 2015, 10:32 p.m.) Review request for kafka. Bugs: KAFKA-2191

Re: Review Request 34170: Patch for KAFKA-2191

> On May 13, 2015, 5:14 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java, > > line 126 > > > > > > how come we are removing the event count threshold. Oh.. My ba

Re: Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review83629 --- clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.ja

Review Request 34170: Patch for KAFKA-2191

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/ --- Review request for kafka. Bugs: KAFKA-2191 https://issues.apache.org/jira/b