----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34170/#review83629 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java <https://reviews.apache.org/r/34170/#comment134631> Is this actually right? I agree you'll get discontinuities as the measured time shrinks to zero but why is giving back 0 the right answer? In the case you guys were testing 0 was safe, but imagine a case where the monitoring was checking that the value didn't fall below some threshold. clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java <https://reviews.apache.org/r/34170/#comment134633> how come we are removing the event count threshold. - Jay Kreps On May 13, 2015, 3:47 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34170/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 3:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2191 > https://issues.apache.org/jira/browse/KAFKA-2191 > > > Repository: kafka > > > Description > ------- > > KAFKA-2191; Measured rate should not be infinite > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java > 98429da34418f7f1deba1b5e44e2e6025212edb3 > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java > b341b7daaa10204906d78b812fb05fd27bc69373 > > Diff: https://reviews.apache.org/r/34170/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
