Re: Review Request 33552: Patch for KAFKA-2142

2015-05-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/#review84191 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated May 5, 2015, 1:15 a.m.) Review request for kafka. Bugs: KAFKA-2142

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated May 5, 2015, 1:14 a.m.) Review request for kafka. Bugs: KAFKA-2142

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated May 5, 2015, 12:57 a.m.) Review request for kafka. Bugs: KAFKA-2142

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Jiangjie Qin
> On May 4, 2015, 9:34 p.m., Guozhang Wang wrote: > > Some general comments: > > > > 1. This patch seems trying to fix multiple issues all at once, which makes > > it very hard to reason / review. Could you separate it into multiple phases > > with each phase resolving one issue at a time? > >

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated May 5, 2015, 12:19 a.m.) Review request for kafka. Bugs: KAFKA-2142

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/#review82444 --- Some general comments: 1. This patch seems trying to fix multiple i

Re: Review Request 33552: Patch for KAFKA-2142

2015-05-02 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated May 2, 2015, 6:59 p.m.) Review request for kafka. Bugs: KAFKA-2142

Re: Review Request 33552: Patch for KAFKA-2142

2015-04-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated April 25, 2015, 6:49 p.m.) Review request for kafka. Bugs: KAFKA-214

Re: Review Request 33552: Patch for KAFKA-2142

2015-04-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated April 25, 2015, 6:48 p.m.) Review request for kafka. Bugs: KAFKA-214

Re: Review Request 33552: Patch for KAFKA-2142

2015-04-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated April 25, 2015, 6:25 p.m.) Review request for kafka. Bugs: KAFKA-214

Re: Review Request 33552: Patch for KAFKA-2142

2015-04-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- (Updated April 25, 2015, 6:22 p.m.) Review request for kafka. Bugs: KAFKA-214

Review Request 33552: Patch for KAFKA-2142

2015-04-25 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33552/ --- Review request for kafka. Bugs: KAFKA-2142 https://issues.apache.org/jira/b