-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/
-----------------------------------------------------------
(Updated April 25, 2015, 6:25 p.m.)
Review request for kafka.
Bugs: KAFKA-2142
https://issues.apache.org/jira/browse/KAFKA-2142
Repository: kafka
Description (updated)
-------
Patch for KAFKA-2142
Summary of things that are changed:
1. Check node ready before checking data ready.
2. Added next data ready check after draining data.
3. Fixed bug to honor linger.ms when drain
4. Fixed bug of checking unknown leader.
5. Fixed bug of node ready check could still be true even if metadata update is
inprogress.
6. Added some unit tests.
I think this patch can also help KAFKA-1788. I was not trying to piggybag the
solution to KAFKA-1788 in this patch, but hopefully with this patch it should
be easier to sovle that issue.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/Metadata.java
07f1cdb1fe920b0c7a5f2d101ddc40c689e1b247
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
b7ae595f2cc46e5dfe728bc3ce6082e9cd0b6d36
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
09ecb427c9f4482dd064428815128b1c426dc921
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
42b12928781463b56fc4a45d96bb4da2745b6d95
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
49a98838767615dd952da20825f6985698137710
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
06182db1c3a5da85648199b4c0c98b80ea7c6c0c
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
b2db91ca14bbd17fef5ce85839679144fff3f689
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
928087d29deb80655ca83726c1ebc45d76468c1f
clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
8b278892883e63899b53e15efb9d8c926131e858
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java
b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
419541011d652becf0cda7a5e62ce813cddb1732
clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java
baa48e7c1b7ac5da8f3aca29f653c3fff88f8009
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java
8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4
clients/src/test/resources/log4j.properties
b1d5b7f2b4091040bdcfb0a60fd58111179f45a0
core/src/test/resources/log4j.properties
1b7d5d8f7d5fae7d272849715714781cad05d77b
Diff: https://reviews.apache.org/r/33552/diff/
Testing
-------
Unit Test passed.
Thanks,
Jiangjie Qin
