Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review83332 --- Ship it! Ship It! - Guozhang Wang On April 25, 2015, 8:35 p.m.,

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81693 --- Ship it! Ship It! - Aditya Auradkar On April 25, 2015, 8:35 p.m.

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/ --- (Updated April 25, 2015, 8:35 p.m.) Review request for kafka. Bugs: KAFKA-215

Re: Review Request 33551: Patch for KAFKA-2150

> On April 25, 2015, 7:20 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 95 > > > > > > I was thinking that you could still process the fetchRequest outside > > the

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/ --- (Updated April 25, 2015, 8:18 p.m.) Review request for kafka. Bugs: KAFKA-215

Re: Review Request 33551: Patch for KAFKA-2150

> On April 25, 2015, 7:20 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 95 > > > > > > I was thinking that you could still process the fetchRequest outside > > the

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/ --- (Updated April 25, 2015, 8:14 p.m.) Review request for kafka. Bugs: KAFKA-215

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81596 --- core/src/main/scala/kafka/server/AbstractFetcherThread.scala

Re: Review Request 33551: Patch for KAFKA-2150

> On April 25, 2015, 4:18 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 95 > > > > > > The way this function is implemented, it potentially acquires the same > > lo

Re: Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81593 --- Minor comment. core/src/main/scala/kafka/server/AbstractFetcherThr

Review Request 33551: Patch for KAFKA-2150

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/ --- Review request for kafka. Bugs: KAFKA-2150 https://issues.apache.org/jira/b