> On April 25, 2015, 7:20 p.m., Aditya Auradkar wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 95 > > <https://reviews.apache.org/r/33551/diff/1/?file=941643#file941643line95> > > > > I was thinking that you could still process the fetchRequest outside > > the locked segment. Is there a reason a flag wouldn't work?
We went back from using a flag to fetchRequest in KAFKA-1461. I updated the patch to use the existing lock to wait if the fetchRequest is empty. Can you please take a look. Thanks. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81596 ----------------------------------------------------------- On April 25, 2015, 8:14 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33551/ > ----------------------------------------------------------- > > (Updated April 25, 2015, 8:14 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2150 > https://issues.apache.org/jira/browse/KAFKA-2150 > > > Repository: kafka > > > Description > ------- > > KAFKA-2150. FetcherThread backoff need to grab lock before wait on condition. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > a439046e118b6efcc3a5a9d9e8acb79f85e40398 > > Diff: https://reviews.apache.org/r/33551/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
