Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

2015-06-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review87450 --- Ship it! Thanks for the patch. +1. Just some minor comments below.

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

2015-06-08 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 9, 2015, 3:02 a.m.) Review request for kafka. Summary (updated)