----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review87450 -----------------------------------------------------------
Ship it! Thanks for the patch. +1. Just some minor comments below. core/src/main/scala/kafka/log/FileMessageSet.scala <https://reviews.apache.org/r/33204/#comment139760> Need space after if to be consistent with the rest of the code. There are a few other places like that. core/src/main/scala/kafka/log/FileMessageSet.scala <https://reviews.apache.org/r/33204/#comment139764> It's probably clearer if we wrap this in {}. core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/33204/#comment139767> This check is not necessary since we already verify that the segment size is larger than 0 when parsing the configuration. core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/33204/#comment139765> need set => need to set core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala <https://reviews.apache.org/r/33204/#comment139768> FileMessageSEt => FileMessageSet core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala <https://reviews.apache.org/r/33204/#comment139769> clear shutdown => cleanly shut down core/src/test/scala/unit/kafka/log/LogSegmentTest.scala <https://reviews.apache.org/r/33204/#comment139772> clear shutdown => clean shutdown - Jun Rao On June 9, 2015, 3:02 a.m., Honghai Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33204/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 3:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1646 > https://issues.apache.org/jira/browse/KAFKA-1646 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-1646 merge to latest trunk > > > Diffs > ----- > > core/src/main/scala/kafka/log/FileMessageSet.scala > 2522604bd985c513527fa0c863a7df677ff7a503 > core/src/main/scala/kafka/log/Log.scala > 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 > core/src/main/scala/kafka/log/LogConfig.scala > a907da09e1ccede3b446459225e407cd1ae6d8b3 > core/src/main/scala/kafka/log/LogSegment.scala > ed039539ac18ea4d65144073915cf112f7374631 > core/src/main/scala/kafka/server/KafkaConfig.scala > 2d75186a110075e0c322db4b9f7a8c964a7a3e88 > core/src/main/scala/kafka/server/KafkaServer.scala > b320ce9f6a12c0ee392e91beb82e8804d167f9f4 > core/src/main/scala/kafka/utils/CoreUtils.scala > d0a8fa701564b4c13b3cd6501e1b6218d77e8e06 > core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala > cec1caecc51507ae339ebf8f3b8a028b12a1a056 > core/src/test/scala/unit/kafka/log/LogSegmentTest.scala > 03fb3512c4a4450eac83d4cd4b0919baeaa22942 > > Diff: https://reviews.apache.org/r/33204/diff/ > > > Testing > ------- > > > Thanks, > > Honghai Chen > >
