Re: Review Request 33204: Patch for KAFKA-1646 Fix2TestCasesAndLogClean

2015-06-18 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 19, 2015, 5:55 a.m.) Review request for kafka. Summary (updated

Re: Review Request 33204: Patch for KAFKA-1646 fix format

2015-06-16 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 16, 2015, 7:34 a.m.) Review request for kafka. Summary (updated

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

2015-06-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review87450 --- Ship it! Thanks for the patch. +1. Just some minor comments below.

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

2015-06-08 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 9, 2015, 3:02 a.m.) Review request for kafka. Summary (updated)

Re: Review Request 33204: Patch for KAFKA-1646 add test cases

2015-05-20 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review84554 --- Ship it! This looks good to be, but it would be good to get a secon

Re: Review Request 33204: Patch for KAFKA-1646 add test cases

2015-05-11 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated May 11, 2015, 10 a.m.) Review request for kafka. Summary (updated) -

Re: Review Request 33204: Patch for KAFKA-1646

2015-04-22 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated April 22, 2015, 10:13 a.m.) Review request for kafka. Bugs: KAFKA-16

Review Request 33204: Patch for KAFKA-1646

2015-04-14 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- Review request for kafka. Bugs: KAFKA-1646 https://issues.apache.org/jira/b