Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review78166 --- Ship it! Ship It! - Neha Narkhede On March 27, 2015, 6:58 p.m.,

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 27, 2015, 6:58 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review78018 --- Ship it! Thanks for the patch. +1. Just a couple of minor comments

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 27, 2015, 12:44 a.m.) Review request for kafka. Bugs: KAFKA-15

Re: Review Request 31967: Patch for KAFKA-1546

> On March 25, 2015, 9:25 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Replica.scala, lines 60-72 > > > > > > Instead of pass these fiels of logReadResult all the way up to the > > replica, I think

Re: Review Request 31967: Patch for KAFKA-1546

> On March 26, 2015, 12:07 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/cluster/Replica.scala, lines 52-72 > > > > > > Would it be simpler to instead keeping track of a lastCaughtUpTime and > > updating it every

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review77810 --- Thanks for the new patch. A couple of more comments. core/src/main

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review77799 --- core/src/main/scala/kafka/cluster/Replica.scala

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 25, 2015, 8:27 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 17, 2015, 9:46 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76781 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76641 --- lgtm overall. Minor comments below. core/src/test/scala/unit/kafka

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 16, 2015, 6:32 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 16, 2015, 6:31 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76585 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76571 --- Working on the remaining comments. Shall update the RB core/src/ma

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76517 --- Thanks for the patch. A few comments below. core/src/main/scala/ka

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76511 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 12, 2015, 8:42 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 12, 2015, 8:42 p.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 12, 2015, 3:17 a.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 12, 2015, 1:48 a.m.) Review request for kafka. Bugs: KAFKA-154

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- (Updated March 12, 2015, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-154

Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/ --- Review request for kafka. Bugs: KAFKA-1546 https://issues.apache.org/jira/b