Re: Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

2015-03-11 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31925/#review76149 --- Ship it! Makes sense. Not a committer but looks good to me :) Unit

Re: Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

2015-03-11 Thread Blake Smith
> On March 11, 2015, 8:39 p.m., Jiangjie Qin wrote: > > Works for me but still see the following line: > > there were 12 feature warning(s); re-run with -feature for details > > I tried ./gradlew jar -feature, but it seems does not work at all. If this > > is the related issue, can we solve it i

Re: Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

2015-03-11 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31925/#review76122 --- Works for me but still see the following line: there were 12 feature

Review Request 31925: KAFKA-1054: Fix remaining compiler warnings

2015-03-10 Thread Blake Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31925/ --- Review request for kafka. Bugs: KAFKA-1054 https://issues.apache.org/jira/b