Re: Review Request 31260: Patch for kafka-1971

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/#review73592 --- Ship it! +1 if the comment below is fixed. core/src/test/scala/un

Re: Review Request 31260: Patch for kafka-1971

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/ --- (Updated Feb. 23, 2015, 5:11 a.m.) Review request for kafka. Bugs: kafka-1971

Re: Review Request 31260: Patch for kafka-1971

> On Feb. 21, 2015, 6:14 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaHealthcheck.scala, line 53 > > > > > > We should try to understand why we need to explicitly de-register here. > > It isn't

Re: Review Request 31260: Patch for kafka-1971

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/#review73411 --- Can we add a unit test in ServerStartupTest? core/src/main/scala/k

Review Request 31260: Patch for kafka-1971

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/ --- Review request for kafka. Bugs: kafka-1971 https://issues.apache.org/jira/b