----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31260/#review73411 -----------------------------------------------------------
Can we add a unit test in ServerStartupTest? core/src/main/scala/kafka/server/KafkaHealthcheck.scala <https://reviews.apache.org/r/31260/#comment119748> Even if there is a good reason to explicitly register, isn't a better strategy to check if the broker is deleting it's own registration based on the node's data? core/src/main/scala/kafka/server/KafkaHealthcheck.scala <https://reviews.apache.org/r/31260/#comment119747> We should try to understand why we need to explicitly de-register here. It isn't immediately clear to me. - Neha Narkhede On Feb. 21, 2015, 4:16 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31260/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 4:16 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1971 > https://issues.apache.org/jira/browse/kafka-1971 > > > Repository: kafka > > > Description > ------- > > KAFKA-1971; starting a broker with a conflicting id will delete the previous > broker registration > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaHealthcheck.scala > 4acdd70fe9c1ee78d6510741006c2ece65450671 > > Diff: https://reviews.apache.org/r/31260/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
