Re: Review Request 31140: Patch for KAFKA-1953

2015-02-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review73176 --- Ship it! Ship It! - Guozhang Wang On Feb. 18, 2015, 2:23 a.m., J

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/ --- (Updated Feb. 18, 2015, 2:23 a.m.) Review request for kafka. Bugs: KAFKA-1953

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
> On Feb. 18, 2015, 2:06 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, line 286 > > > > > > We can move the debug statement out of the synchronized block. Good point. > On F

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review72875 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review72849 --- Couple of comments to call out. core/src/main/scala/kafka/server/D

Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/ --- Review request for kafka. Bugs: KAFKA-1953 https://issues.apache.org/jira/b