----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review72849 -----------------------------------------------------------
Couple of comments to call out. core/src/main/scala/kafka/server/DelayedOperation.scala <https://reviews.apache.org/r/31140/#comment118961> FYI, I tried to avoid doing this. i.e., providing an explicit name. We cannot simply do T.getClass.getName but have to look up manifests: http://stackoverflow.com/questions/8208179/scala-obtaining-a-class-object-from-a-generic-type The previous code avoided this by extending this class. E.g., class ProducerRequestPurgatory extends DelayedOperationPurgatory... I actually prefer the explicit name to that approach because it forces people to think about the name. Otherwise if people forget to extend for multiple purgatory instances then the metrics could collide. core/src/main/scala/kafka/server/DelayedProduce.scala <https://reviews.apache.org/r/31140/#comment118962> Note that this is similar to our expiration recording in the past, although it is slightly weird. i.e., each expired key counts toward the aggregate even if it is all from one single producer request. - Joel Koshy On Feb. 18, 2015, 12:48 a.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31140/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1953 > https://issues.apache.org/jira/browse/KAFKA-1953 > > > Repository: kafka > > > Description > ------- > > KAFKA-1953; KAFKA-1962; Disambiguate purgatory metrics; restore delayed > request metrics > > > Diffs > ----- > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala > 01cf1d91b7056bea7368ae4ea1e3c3646fc33619 > core/src/main/scala/kafka/coordinator/DelayedHeartbeat.scala > 894d6edb4077cae081b9d4039353dd17e6f0c18f > core/src/main/scala/kafka/coordinator/DelayedJoinGroup.scala > 445bfa1bf8840620e10de2456875716dc66e789a > core/src/main/scala/kafka/coordinator/DelayedRebalance.scala > b3b3749a21d35950a975e24dd9d1d53afbfaaee4 > core/src/main/scala/kafka/server/DelayedFetch.scala > dd602ee2e65c2cd4ec363c75fa5d0b3c038b1ed2 > core/src/main/scala/kafka/server/DelayedOperation.scala > fc06b01cad3a0497800df727fa2abf60772694f2 > core/src/main/scala/kafka/server/DelayedProduce.scala > c229088eb4f3db414225a688e149591ae0f810e7 > core/src/main/scala/kafka/server/ReplicaManager.scala > ce36cc72606fb5441335f1c7466a7db8da3db499 > core/src/test/scala/unit/kafka/server/DelayedOperationTest.scala > 93f52d3222fc10b6d22ef6278365f6b026180418 > > Diff: https://reviews.apache.org/r/31140/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
