Re: Review Request 31088: Patch for KAFKA-1959

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/#review72910 --- Ship it! Ship It! - Joel Koshy On Feb. 16, 2015, 4:37 p.m., Tong

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inhe

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/#review72637 --- The rename does make things a bit clearer, so I don't object to comm

Review Request 31088: Patch for KAFKA-1959

2015-02-16 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/ --- Review request for kafka. Bugs: KAFKA-1959 https://issues.apache.org/jira/b