----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1959 https://issues.apache.org/jira/browse/KAFKA-1959 Repository: kafka Description ------- The original code clearly wants to define a string but override the ThreadGroup of the super class member. The patchset will rename the private variable to be group_id as it intended. Diffs ----- core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 Diff: https://reviews.apache.org/r/31088/diff/ Testing ------- Thanks, Tong Li