Re: Review Request 30809: Patch for KAFKA-1888

> On April 2, 2015, 1:38 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, lines 431-437 > > > > > > Could we add a description of the test (what kind of data is generated, > > ho

Re: Review Request 30809: Patch for KAFKA-1888

> On March 31, 2015, 9:20 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 1 > > > > > > This should definitely not be in tools - this should probably live > > somewhere un

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review78630 --- Thanks for the patch. A few high level comments. 1. I think we are

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review78270 --- bin/kafka-run-class.sh

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review77732 --- bin/kafka-run-class.sh

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated March 23, 2015, 6:54 p.m.) Review request for kafka. Bugs: KAFKA-188

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76835 --- Also, I think we can move ValidatingProducer/Consumer and BoostrapCo

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76103 --- There some coding convention suggestions that may not be comprehensi

Re: Review Request 30809: Patch for KAFKA-1888

> On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183 > > > > > > This is essentially a sync approach, can we use callback to do this? > > Abh

Re: Review Request 30809: Patch for KAFKA-1888

> On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183 > > > > > > This is essentially a sync approach, can we use callback to do this? > > Abh

Re: Review Request 30809: Patch for KAFKA-1888

> On March 11, 2015, 11:12 p.m., Gwen Shapira wrote: > > This looks like a very good start. I think the framework is flexible enough > > to allow us to add a variety of upgrade tests. I'm looking forward to it. > > > > > > I have few comments, but mostly I'm still confused on how this will be

Re: Review Request 30809: Patch for KAFKA-1888

> On March 12, 2015, 12:13 a.m., Jiangjie Qin wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 183 > > > > > > This is essentially a sync approach, can we use callback to do this? This is

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76173 --- core/src/main/scala/kafka/tools/ContinuousValidationTest.java

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76157 --- This looks like a very good start. I think the framework is flexible

Re: Review Request 30809: Patch for KAFKA-1888

> On March 10, 2015, 11:44 p.m., Guozhang Wang wrote: > > This is from some old review comments, I will upload rest of them soon. - Guozhang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review73382 --- build.gradle

Re: Review Request 30809: Patch for KAFKA-1888

> On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 400 > > > > > > The common format of commenting is : > > > > // this is a comment

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review73061 --- core/src/main/scala/kafka/tools/ContinuousValidationTest.java

Re: Review Request 30809: Patch for KAFKA-1888

> On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 168 > > > > > > same here can we use isInterrupted()? > > > > > > http://docs.ora

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated March 9, 2015, 11:55 p.m.) Review request for kafka. Bugs: KAFKA-188

Re: Review Request 30809: Patch for KAFKA-1888

> On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 207 > > > > > > This might end up in infinite loop if something goes wrong with > > cluste

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated Feb. 18, 2015, 1:59 a.m.) Review request for kafka. Bugs: KAFKA-1888

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 --- core/src/main/scala/kafka/tools/ContinuousValidationTest.java

Re: Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated Feb. 9, 2015, 11:53 p.m.) Review request for kafka. Bugs: KAFKA-1888

Review Request 30809: Patch for KAFKA-1888

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- Review request for kafka. Bugs: KAFKA-1888 https://issues.apache.org/jira/b