> On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 168 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line168> > > > > same here can we use isInterrupted()? > > > > > > http://docs.oracle.com/javase/tutorial/essential/concurrency/interrupt.html
I want to check if the current thread is interrupted. The link you sent out is useful if I wanted to query whether another thread was interrupted. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 280 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line280> > > > > Can we put this in a separate method like init(). > > Constructor can be used mainly for assignment. what do you think? Moved the launching of the threads to an init method. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 298 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line298> > > > > When is the blockingCallInterrupted set to true? Got rid of this. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 324 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line324> > > > > formatting spaces. > > > > Will there be a case where : > > (evt.sequenceId < lastEventSeenSequenceId.get() && > > evt.eventProducedTimestamp > lastEventSeenTimeProduced.get() This will happen when the sequence numbers wraparound. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 61 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line61> > > > > Any reason for not making this final? > > > > static variables should come before Instance variables. > > > > Its a common standard to specify instance variables with _ like : > > _groupId. Fixed this. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 ----------------------------------------------------------- On March 9, 2015, 11:55 p.m., Abhishek Nigam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30809/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 11:55 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1888 > https://issues.apache.org/jira/browse/KAFKA-1888 > > > Repository: kafka > > > Description > ------- > > Fixing the tests based on Mayuresh comments, code cleanup after proper IDE > setup > > > Diffs > ----- > > build.gradle 0f0fe60a74542efa91a0e727146e896edcaa38af > core/src/main/scala/kafka/tools/ContinuousValidationTest.java PRE-CREATION > system_test/broker_upgrade/bin/kafka-run-class.sh PRE-CREATION > system_test/broker_upgrade/bin/test.sh PRE-CREATION > system_test/broker_upgrade/configs/server1.properties PRE-CREATION > system_test/broker_upgrade/configs/server2.properties PRE-CREATION > system_test/broker_upgrade/configs/zookeeper_source.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/30809/diff/ > > > Testing > ------- > > Scripted it to run 20 times without any failures. > Command-line: broker-upgrade/bin/test.sh <dir1> <dir2> > > > Thanks, > > Abhishek Nigam > >
