Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review84107 --- It took me a while to get back to contributing. I have now updated t

Re: Review Request 30403: Patch for KAFKA-1906

> On Feb. 7, 2015, 4:41 p.m., Neha Narkhede wrote: > > config/server.properties, line 58 > > > > > > Why leave the value here to point at /tmp/kafka-logs? The way I see is > > that we default the log directory to data/

Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/ --- (Updated May 18, 2015, 4:42 a.m.) Review request for kafka. Bugs: KAFKA-1906

Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review71557 --- config/server.properties

Re: Review Request 30403: Patch for KAFKA-1906

While I appreciate production-grade configs a lot, I prefer to ship with usable-out-of-the-box configs. I suspect that large part of the amazing adoption that projects like MySQL, MongoDB, Cassandra and Kafka had is how easy it is to install and get going on a local dev box. Working as DB Architec

Re: Review Request 30403: Patch for KAFKA-1906

+1 on including a reasonable default for log.dirs that points to data/ in the installation directory. This is followed by some other systems and is probably a little better compared to /tmp. Also, I actually think we should default to production ready settings for most configs, at least those rela

Re: Review Request 30403: Patch for KAFKA-1906

Yeah I second Jaikiran's take: I think we should stick to something that works "out of the box" without editing config. I think the experience here is important, and adding one manual configuration step quickly cascades into a bunch of these steps (since it is always easier to make something manual

Re: Review Request 30403: Patch for KAFKA-1906

Yep I totally get that. But...you already have to modify the configs anyway. The primary goals of default values are basically two-fold 1) Get started quickly 2) Provide reasonable values for stuff people don't really know about. I guess I would just rather see people take the time (30s to 1min m

Re: Review Request 30403: Patch for KAFKA-1906

Hi Jeff, I guess you are :) Personally, whenever I download and try a new project *in development environment* I always just want to get it up and running without having to fiddle with configurations. Of course, I do a bit of reading the docs, before trying it out, but I like to have the inst

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

Maybe I'm in the minority here, but I actually don't think there should be a default for this param and you should be required to explicitly set this. On Thu, Jan 29, 2015 at 5:43 AM, Jay Kreps wrote: > > > > On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > > We added --override option to Ka

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:50 a.m., Gwen Shapira wrote: > > We added --override option to KafkaServer that allows overriding default > > configuration from commandline. > > I believe that just changing the shell script to include --override > > log.dir=${KAFKA_HOME}/data > > may be enough? > > > >

Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review70168 --- We added --override option to KafkaServer that allows overriding def

Re: Review Request 30403: Patch for KAFKA-1906

> On Jan. 29, 2015, 6:32 a.m., Sriharsha Chintalapani wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 149 > > > > > > I am not sure all of these code changes necessary. Instead change the > > defau

Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review70163 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/ --- (Updated Jan. 29, 2015, 6:24 a.m.) Review request for kafka. Changes ---

Review Request 30403: Patch for KAFKA-1906

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/ --- Review request for kafka. Bugs: KAFKA-1906 https://issues.apache.org/jira/b