----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review84107 -----------------------------------------------------------
It took me a while to get back to contributing. I have now updated this patch to incorporate Neha's review comments. This is now ready to be reviewed again. - Jaikiran Pai On May 18, 2015, 4:42 a.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30403/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 4:42 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1906 > https://issues.apache.org/jira/browse/KAFKA-1906 > > > Repository: kafka > > > Description > ------- > > KAFKA-1906 Default the Kafka data log directory to > $KAFKA_HOME/data/kafka-logs directory, where KAFKA_HOME is the Kafka > installation directory > > > Diffs > ----- > > bin/kafka-run-class.sh 8c3fa286145344fb527307012c1d1000d855aa18 > bin/windows/kafka-run-class.bat 4aa2ab8ddb9bf56c26fc1c292f359e50b40461e5 > config/server.properties 80ee2fc6e94a114e7710ae4df3f4e2b83e06f080 > core/src/main/scala/kafka/server/KafkaConfig.scala > 9efa15ca5567b295ab412ee9eea7c03eb4cdc18b > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2428dbd7197a58cf4cad42ef82b385dab3a2b15e > > Diff: https://reviews.apache.org/r/30403/diff/ > > > Testing > ------- > > The change here involves updating the Kafka scripts (for Windows and * nix) > to infer and setup KAFKA_HOME environment variable. This value is then used > by the KafkaConfig to decide what path to default to for the Kafka data logs, > in the absence of any explicitly set log.dirs (or log.dir) properties. > > Care has been taken to ensure that other mechanism which might presently be > bypassing the Kafka scripts, will still continue to function, since in the > absence of KAFKA_HOME environment property value, we fall back to > /tmp/kafka-logs (the present default) as the default data log directory > > Existing tests have been run to ensure that this change maintains backward > compatibility (i.e. doesn't fail when KAFKA_HOME isn't available/set) and 2 > new test methods have been added to the KafkaConfigTest to ensure that this > change works. > > Although the change has been made to both .sh and .bat files, to support > this, I haven't actually tested this change on a Windows OS and would > appreciate if someone can test this there and let me know if they run into > any issues. > > > Thanks, > > Jaikiran Pai > >
