Re: Review Request 30199: Patch for KAFKA-1890

2015-01-23 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69405 --- Ship it! Ship It! - Neha Narkhede On Jan. 23, 2015, 3:57 a.m., J

Re: Review Request 30199: Patch for KAFKA-1890

2015-01-22 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/ --- (Updated 一月 23, 2015, 3:57 a.m.) Review request for kafka. Bugs: KAFKA-1890

Re: Review Request 30199: Patch for KAFKA-1890

2015-01-22 Thread Jiangjie Qin
> On 一月 23, 2015, 3:14 a.m., Joe Stein wrote: > > Can you add test cases for the failure please? We should be able to apply > > the test cases, run test, see the failure, apply fix, verify the success. > > Thanks! It was actually a pretty silly mistake I made. Mirror maker will always have NP

Re: Review Request 30199: Patch for KAFKA-1890

2015-01-22 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69337 --- Can you add test cases for the failure please? We should be able to

Re: Review Request 30199: Patch for KAFKA-1890

2015-01-22 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69302 --- Ship it! Ship It! - Gwen Shapira On Jan. 22, 2015, 11:25 p.m., J

Review Request 30199: Patch for KAFKA-1890

2015-01-22 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/ --- Review request for kafka. Bugs: KAFKA-1890 https://issues.apache.org/jira/b