----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30199/#review69337 -----------------------------------------------------------
Can you add test cases for the failure please? We should be able to apply the test cases, run test, see the failure, apply fix, verify the success. Thanks! - Joe Stein On Jan. 22, 2015, 11:25 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30199/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 11:25 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1890 > https://issues.apache.org/jira/browse/KAFKA-1890 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-1890 > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 5cbc8103e33a0a234d158c048e5314e841da6249 > > Diff: https://reviews.apache.org/r/30199/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >